Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
document old way of checking validity of CSRF token#5340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
snoek09 commentedMay 30, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes |
| Applies to | all |
| Fixed tickets | Related to#4668 |
book/controller.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please move themethod role on its own line?
snoek09 commentedJun 2, 2015
@xabbuh done, please let me know if this needs any other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I feel that this sentence should be worded more "smoothy". Though I'm not sure how. Maybe our native speaker@weaverryan has a suggestion.
xabbuh commentedOct 20, 2015
@snoek09 I am sorry for the delay here. Do you think we should still tackle this and reopen the PR in that case? |
snoek09 commentedOct 20, 2015
I closed this because it is already merged into 2.6:85dc294 |
xabbuh commentedOct 20, 2015
Indeed, but it seems to be missing in the 2.7 version of the docs if I don't miss anything. |
xabbuh commentedOct 20, 2015
see#5816 |
snoek09 commentedOct 20, 2015
In that case, just re-use the text and change it where needed. |
xabbuh commentedOct 20, 2015
@snoek09 Sorry for poking you again. I had a look at this again and I think we should actually merge this one so that we have a description in the 2.3 docs too. What do you think? |
snoek09 commentedOct 20, 2015
As I deleted the related fork a while back and closed this PR I can't reopen this. New PR is here:#5818 |