Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
4668 document isCsrfTokenValid#5325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
snoek09 commentedMay 28, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes |
| Applies to | 2.6 |
| Fixed tickets | #4668 |
book/controller.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For consistency with other parts of the doc, there should be a comment showing the alternative not using the shortcut
book/controller.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We always use "was introduced in".
xabbuh commentedMay 30, 2015
@snoek09 Thank you for your contribution. Do you also like to open a pull request for the |
snoek09 commentedMay 30, 2015
book/controller.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please move themethod role to its own line?
snoek09 commentedJun 2, 2015
@xabbuh done, please let me know if this needs any other changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I prefer something like this:
..versionadded::2.6 The ``isCsrfTokenValid()`` shortcut method was introduced in Symfony 2.6. It is equivalent to executing the following code:: use Symfony\Component\Security\Csrf\CsrfToken; $this->get('security.csrf.token_manager')->isTokenValid(new CsrfToken('token_id', 'TOKEN'));
wouterj commentedJul 28, 2015
👍 (apart from my 2 comments, but these can be fixed by the merger quite easily) |
snoek09 commentedJul 28, 2015
This PR was squashed before being merged into the 2.6 branch (closes#5572).Discussion----------4668 document isCsrfTokenValid| Q | A| ------------- | ---| Doc fix? | yes| New docs? | yes| Applies to | 2.6| Fixed tickets |#4668See original PR#5325 for comments.Commits-------11383f8 4668 document isCsrfTokenValid