Rebase of #4989#5099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

weaverryan wants to merge6 commits into2.6fromsolazs-patch-1

Closed

Rebase of #4989#5099

weaverryan wants to merge6 commits into2.6fromsolazs-patch-1

Conversation

Copy link

Member

weaverryan commentedMar 20, 2015

Just a PR after rebasing#4989, which had some extra commits.

This will be committed to the 2.3 branch.

solazsand others added6 commits

March 19, 2015 21:08

Update translation.rst

af46923

Clarify that changing the locale in the controller would not affect template rendering as the translator reads the request locale during the kernel.request event.

Review note about setting the translator locale in a controller.

1bfc46d

Finaly touches on translation locale setting note

d38e3eb

Remove useless setLocale() call and add code block with locale setter

65e39b1

[#4989] Language tweaks and making the example simpler

4075393

Moving index down to correct section

bfb6207

weaverryan mentioned this pull request

Mar 20, 2015

Update translation.rst#4989

Closed

weaverryan added a commit that referenced this pull request

Mar 20, 2015

feature#5099Rebase of#4989(solazs, weaverryan)

e36faec

This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes#5099).Discussion----------Rebase of#4989Just a PR after rebasing#4989, which had some extra commits.This will be committed to the 2.3 branch.Commits-------006303d Moving index down to correct section7281c53 [#4989] Language tweaks and making the example simpler1ad8122 Remove useless setLocale() call and add code block with locale setter43b2098 Finaly touches on translation locale setting note79f5865 Review note about setting the translator locale in a controller.3b136c8 Update translation.rst