Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Reviewed Configuration cookbook articles#5098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Reviewed Configuration cookbook articles#5098
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedMar 19, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | - |
| One of these ways is by letting Apache handle routes directly, rather than using Symfony for this task. | ||
| Symfony, while fast out of the box, also provides various ways to increase that | ||
| speed with a little bit of tweaking. One of these ways is by letting Apache | ||
| handle routes directly, rather than using Symfony for this task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TheApacheUrlMatcher as well as theApacheMatcherDumper are deprecated. Should we add warning about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yea, I think we should - I think this whole "article" is deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've added a note about not using Apache Router inaedaccd. Please tell me if it's OK. Thanks.
| @@ -80,6 +80,8 @@ method:: | |||
| Here you have changed the location of the directory to ``app/{environment}/logs``. | |||
| .. _override-web-directory: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why adding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ah, see now. For consistency, I would preferoverride-web-dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good point! I've updated the reference name. Thanks.
| @@ -93,7 +103,7 @@ Which should roughly output the following: | |||
| # hello | |||
| RewriteCond %{REQUEST_URI} ^/hello/([^/]+?)$ | |||
| RewriteRule .* app.php [QSA,L,E=_ROUTING__route:hello,E=_ROUTING_name:%1,E=_ROUTING__controller:AppBundle\:Demo\:hello] | |||
| RewriteRule .* app.php [QSA,L,E=_ROUTING__route:hello,E=_ROUTING_name:%1,E=_ROUTING__controller:AppBundle\:Default\:hello] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should beGreet, correct? To match the_controller above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed at sha:808383b
This PR was merged into the 2.3 branch.Discussion----------Reviewed Configuration cookbook articles| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | -Commits-------aedaccd Added a note against using the Apache Router2feb801 Implemented all the changes suggested by reviewers9f49497 Reviewed Configuration cookbook articles
Thanks for all the re-reads Javier - I think it's very helpful! |
* 2.3: [#5098] Minor fix so controller in dumped apache matches _controller route information above fix code block order Update process.rst [Cookbook] Add warning about Composer dev deps on Heroku Added a note against using the Apache Router Implemented all the changes suggested by reviewers Minor rewording Reviewed Configuration cookbook articles Reviewed Cache cookbook articles
* 2.6: [#5098] Minor fix so controller in dumped apache matches _controller route information above fix code block order Update process.rst [Cookbook] Add warning about Composer dev deps on Heroku Added a note against using the Apache Router Implemented all the changes suggested by reviewers Minor rewording Reviewed Configuration cookbook articles Reviewed Cache cookbook articles
* 2.8: [#5098] Minor fix so controller in dumped apache matches _controller route information above fix code block order Update process.rst [Cookbook] Add warning about Composer dev deps on Heroku Added a note against using the Apache Router Implemented all the changes suggested by reviewers Minor rewording Reviewed Configuration cookbook articles Reviewed Cache cookbook articles
…roller route information above