Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Reviewed the Assetic cookbook articles#5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

javiereguiluz
Copy link
Member

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets-

Now you can execute the ``uglifyjs`` command that lives in the ``node_modules``
directory:

.. code-block:: bash

$ ./app/Resources/node_modules/.bin/uglifyjs --help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for windows compatbility, the path should be in double quotes

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You mean like this?

$ "./app/Resources/node_modules/.bin/uglifyjs" --help

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yes

2015-03-19 11:41 GMT+01:00 Javier Eguiluznotifications@github.com:

In cookbook/assetic/uglifyjs.rst
#5094 (comment):

  • $ uglifyjs --help
    +Now you can execute theuglifyjs command that lives in thenode_modules
    +directory:

+.. code-block:: bash

$ ./app/Resources/node_modules/.bin/uglifyjs --help

You mean like this?

$ "./app/Resources/node_modules/.bin/uglifyjs" --help


Reply to this email directly or view it on GitHub
https://github.com/symfony/symfony-docs/pull/5094/files#r26743251.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done. Thanks.

@wouterj
Copy link
Member

👍

@@ -204,7 +204,7 @@ Combining Assets
~~~~~~~~~~~~~~~~

One feature of Assetic is that it will combine many files into one. This helps
to reduce the number of HTTP requests, which is great forfront end performance.
to reduce the number of HTTP requests, which is great forfrontend performance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure about this change. While I agree that "frontend" looks most beautiful, it seems that "front-end" actually would be more correct (see also#4671 (comment)).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

both Bower and Bootstrap (on their homepages) usefront-end. That looks a bit odd to me, but I guess we should follow their lead.

@weaverryanweaverryan merged commit22ccd76 intosymfony:2.3Mar 22, 2015
weaverryan added a commit that referenced this pull requestMar 22, 2015
This PR was merged into the 2.3 branch.Discussion----------Reviewed the Assetic cookbook articles| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets | -Commits-------22ccd76 Fixed a path for Windowsf418e20 Reviewed the Assetic cookbook articles
@weaverryan
Copy link
Member

I love having a fresh set of eyes on these - thanks!@xabbuh Idid remove themkdir at sha:20dcc3c. You're right - these are not needed.

Cheers!

weaverryan added a commit that referenced this pull requestMar 24, 2015
* 2.3: (44 commits)  Removed duplicate "long"s  terminate file with newline  move title back and move description to separate file as suggested in PR#4892  move title out of included file as suggested in PR#4892  Add possible values for widget_type  [#4842] Making 2 sentences  changes as suggested by WouterJ in pull request#4842  Add meaning of yellow icon for number of queries  Fixing bad link name  fix typo in event flow diagrams  Many fixes thanks to stof, WouterJ, xabbuh and dupuchba  added Jakub as a merger for the DomCrawler component  [#5094] Removing mkdir - it's not needed (thanks xabbuh)  some tweaks to#4601  Moving index down to correct section  [#4989] Language tweaks and making the example simpler  Remove useless setLocale() call and add code block with locale setter  Finaly touches on translation locale setting note  Review note about setting the translator locale in a controller.  Update translation.rst  ...Conflicts:cookbook/security/entity_provider.rst
weaverryan added a commit that referenced this pull requestMar 24, 2015
* 2.6: (45 commits)  Removed duplicate "long"s  terminate file with newline  move title back and move description to separate file as suggested in PR#4892  move title out of included file as suggested in PR#4892  Add possible values for widget_type  [#4842] Making 2 sentences  changes as suggested by WouterJ in pull request#4842  Add meaning of yellow icon for number of queries  Fixing bad link name  fix typo in event flow diagrams  Many fixes thanks to stof, WouterJ, xabbuh and dupuchba  added Jakub as a merger for the DomCrawler component  [#5094] Removing mkdir - it's not needed (thanks xabbuh)  some tweaks to#4601  Moving index down to correct section  [#4989] Language tweaks and making the example simpler  Remove useless setLocale() call and add code block with locale setter  Finaly touches on translation locale setting note  Review note about setting the translator locale in a controller.  Update translation.rst  ...
weaverryan added a commit that referenced this pull requestMar 24, 2015
* 2.7: (47 commits)  Removed duplicate "long"s  terminate file with newline  move title back and move description to separate file as suggested in PR#4892  move title out of included file as suggested in PR#4892  Add possible values for widget_type  [#4842] Making 2 sentences  changes as suggested by WouterJ in pull request#4842  Add meaning of yellow icon for number of queries  Fixing bad link name  fix typo in event flow diagrams  Many fixes thanks to stof, WouterJ, xabbuh and dupuchba  added Jakub as a merger for the DomCrawler component  Changes thanks to WouterJ and xabbuh  [#5094] Removing mkdir - it's not needed (thanks xabbuh)  some tweaks to#4601  Moving index down to correct section  [#4989] Language tweaks and making the example simpler  Remove useless setLocale() call and add code block with locale setter  Finaly touches on translation locale setting note  Review note about setting the translator locale in a controller.  ...
@javiereguiluzjaviereguiluz deleted the update_cookbook_assetic branchJanuary 3, 2018 16:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@javiereguiluz@wouterj@weaverryan@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp