Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Update gmail.rst#5085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update gmail.rst#5085
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There are issues with the current docs as they don't address certain user configurations that prevent Symfony from emailing from their app. Mentioning two factor authentication and the less secure app setting is in my opinion, paramount.Reference:http://stackoverflow.com/q/29085617/1188035
cookbook/email/gmail.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is markdown syntax, while this docs is writting in reStructured Text. Please update this PR to use that syntax:
..note:: Depending on your Gmail account settings, you may get authentication errors within your app. You should ensure two-factor authentication and `also allow less secure apps to access your account`_... _`also allow less secure apps to access your account`:https://support.google.com/accounts/answer/6010255
javiereguiluz commentedMar 25, 2015
@sjagr thanks for proposing this improvement! I have a question for you regarding this phrase:
I don't really understand what does it mean. Maybe we could change it for one of these alternatives:
|
Revisions concerning the 2-Step-Verification and correct documentation syntax. Thanks@wouterj and@javiereguiluz
ghost commentedMar 25, 2015
Thanks@wouterj for the format corrections. There can be an alternative suggestion of just turning 2-Step-Verification completely off, but I figured a Gmail user with that setting enabled (such as me) would want to leave it on. |
javiereguiluz commentedJun 11, 2015
This pull request looks finished. If that's true, can we please remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is no need for this line break. Can you also please wrap lines after the first word that crosses the 72nd character instead?
javiereguiluz commentedJun 23, 2015
I'm finishing this PR in#5430. @sjagr don't worry about not having finished your PR. This happens sometimes. I've taken your work and finished it in another PR. I've also reused all your original commits so you get full credit for your work. Thanks. |
xabbuh commentedJun 23, 2015
Thank you for starting this @sjagr! |
There are issues with the current docs as they don't address certain user configurations that prevent Symfony from emailing from their app. Mentioning two factor authentication and the less secure app setting is in my opinion, paramount.
Reference:http://stackoverflow.com/q/29085617/1188035