Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Cookbook about Command in Application with AnsiToHtml#5062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
rvanlaak commentedMar 6, 2015
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | >= 2.3 |
| Fixed tickets | symfony/symfony#11392 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor syntax issue: this line should be as long as its associated headline.
javiereguiluz commentedMar 6, 2015
@rvanlaak thanks for submitting this nice new cookbook! |
rvanlaak commentedMar 6, 2015
Was thinking about addingmore information about the Theming and a code sample about the Twig extension, but seems like that is too much info for the cookbook article. What do you think@javiereguiluz ? |
javiereguiluz commentedMar 6, 2015
@rvanlaak I agree with you: it looks like too much information for this cookbook. I personally love short and straight-to-the-point cookbooks, so I really like your tutorial as it is now. Thanks. |
rvanlaak commentedMar 6, 2015
Another thing, where can I find new decisions the such as the one you mentioned about not using acme examples? Could not find anything onhttp://symfony.com/doc/current/contributing/documentation/index.html and probably such decisions are made in the Google Groups, but we can not follow that the entire day 👍 |
javiereguiluz commentedMar 6, 2015
I don't really know where we decided this, because I talk with doc maintainers via email, IRC and GitHub :( In any case, the#4740 PR is the one which made the biggest recent change to remove I'm going to check if we can add something about this in the formal document that you linked. Thanks for your comments. |
wouterj commentedMar 6, 2015
@rvanlaak we don't use the Google Groups and you sure don't have to watch them in order to contribute something (these reviews are just to help you adding amazing content to the docs, it doesn't matter if your PR isn't 100% correct at first). Decisions like this aren't really strict standards or decisions. As an important rule, it is always better using real-world examples than foobaring your examples. While being more clear, it also works as an advertisement for the framework ("wow, can I also create X with this?"). Since the best practices, we are updating the docs to follow them. One of the most important changes is to no longer recommend using multiple bundles, but just one bundle: AppBundle. We are still in the process of it, as it's a very hard task to do nicely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think something like "How to Call a Command from a Controller" better matches the contents.
xabbuh commentedMar 7, 2015
Thank you for creating the pull request,@rvanlaak. It's nice work. However, I think we should start the text with a short introduction to show use cases when you might want to call a command from a controller. I was thinking about something like:
What do you think? |
rvanlaak commentedMar 8, 2015
Agree with you@xabbuh , so I've updated the example to a real world use case, eg. sending the SwiftMailer spool directly from the controller. Let me know if it's fine now, so I can squash the commits into one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You need to also add a reference to the document in/cookbook/map.rst.inc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Unfortunately, you cannot use literals here.
rvanlaak commentedMar 12, 2015
Rebased the latest changes@javiereguiluz |
javiereguiluz commentedMar 12, 2015
rvanlaak commentedMar 12, 2015
No problem, great way of getting known with the community guidelines 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"[...] from a controller."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this also works in any service? so i am fine with this statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the article is calld "from a controller". So I think we should change this.
rvanlaak commentedApr 9, 2015
Fixed the outstanding issues. Let me know if the commits are ready for a rebase 👍 |
wouterj commentedApr 9, 2015
👍 |
xabbuh commentedApr 12, 2015
👍 Great work@rvanlaak! |
rvanlaak commentedApr 13, 2015
Completed the rebase, squased all commits intorvanlaak@62ae7c3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
i think this is wrong no? why are you not returning a valid HttpResponse instead?
rvanlaak commentedMay 5, 2015
@xabbuh anything I've got to change for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
extends
xabbuh commentedMay 6, 2015
@rvanlaak I left two minor comments. After that I think it's finished. |
... and color coding Ansi output using SensioLabs AnsiToHtmlDocumentation about using Command in Controller... and color coding Ansi output using SensioLabs AnsiToHtmlLine syntaxChange component linkUpdate command_in_controller.rstwith real world example about Swift Mailer.Update command_in_controller.rstAdded command_in_controller to map.rst.incUpdate map.rst.incDocumentation about using Command in ControllerUpdate command_in_controller.rstDocumentation about using Command in ControllerDocumentation about using Command in ControllerUpdate command_in_controller.rstUpdate command_in_controller.rstDocumentation about using Command in Controller
rvanlaak commentedMay 6, 2015
@xabbuh nice pick, fixed and rebased it! |
xabbuh commentedMay 6, 2015
👍 |
…Rvanlaak)This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#5062).Discussion----------Cookbook about Command in Application with AnsiToHtml| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes| Applies to | >= 2.3| Fixed tickets |symfony/symfony#11392Commits-------0799366 Documentation about using Command in Controller
weaverryan commentedMay 23, 2015
Thanks so much@rvanlaak! This is exactly the small, targeted article that we love having. And welcome to the process and thanks for sticking with us through all the reviews. I have now merged this into the 2.3 branch, and opened a new PR -#5299 - with a few further tweaks. If you can review that, it would be awesome. Cheers! |
This PR was merged into the 2.3 branch.Discussion----------Command controller tweaks to#5062| Q | A| ------------- | ---| Doc fix? | yes#5062| New docs? | no| Applies to | 2.3+| Fixed tickets |#5062Hi guys!This is a proofread and bug fix after merging#5062. Notably, I changed to use the `BufferedOutput` and returned a Response from the controller instead of the string.Please let me know if you see any errors - I was coding this right inside the docs 😇.Thanks!Commits-------aad7277 Fixing things thanks to Wouter59f8c95 Tweaks to the new using commands in a controller article