Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
adding table for controller as a service#5033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ``forward`` ``http_kernel`` ``$httpKernel->forward($controller, $path, $query)`` | ||
| ``generateUrl`` ``router`` ``$router->generate($route, $params, $absolute)`` | ||
| ``getDoctrine`` ``doctrine`` | ||
| ``getRequest`` - Use ``Request $request`` as parameter in your action method. The order of the parameters is not important, but the typehint must be there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ugh. is there a way to better format tables in rst?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This syntax (which allows multiline too):
+---------+---------+-----+| Column1| Column2| ...|+=========+=========+=====+| Value 1| multi-| ...||| line 1||+---------+---------+-----+| Value 2| Value 2| ...|+---------+---------+-----+| ...| ...| ...|+---------+---------+-----+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The simple table syntax allows to wrap long lines in several shorter lines:http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#simple-tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
let's remove this row btw, asgetRequest is deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@wouterj one of these days we should standardize the table syntax to use in the documentation. Hopefully, we'll never recommend to use the rigid grid syntax ;)
I like this one :) |
| ``getRequest`` has been deprecated. Instead, have an argument to your | ||
| controller action method called ``Request $request``. The order of the | ||
| parameters is not important, but the typehint must be provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
converted this to a separate tip. i think it does not hurt to mention this here again. the whole doc segment is for people afraid to look at the controller source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
should we mention the table in the introduction of the cookbook article? |
| +-----------------------------+------------------------------------+----------------------------------------------------------------+ | ||
| | Method | Service | PHP Code | | ||
| +=============================+====================================+================================================================+ | ||
| | ``createForm`` | ``form.factory`` | ``$formFactory->create($type, $data, $options)`` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is wrong. You are missing the->getForm() call in the equivalent code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| | | | $token = $securityContext->getToken(); | | ||
| | | | if (null !== $token && is_object($token->getUser())) { | | ||
| | | | $user = $token->getUser(); | | ||
| | | | } | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this renders quite badly (all code lines floating) but i found no way how to include multiline source code in a table cell... ideas? btw, the indention is missing on purpose as otherwise we get a compile error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tables are a hell in Sphinx to get things like this working nicely. I don't know of a nice solution other than not using table...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would suggest to use a definition list instead:
:method:`Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller::createForm` (service: ``form.factory``) ..code-block::php $formFactory->create($type, $data, $options);
and so on
thanks@xabbuh , switched to definition list. the rendering looks ok to me. |
awesome PR 👍 |
| :method:`Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller::createNotFoundException` | ||
| .. code-block:: php | ||
| throw new NotFoundHttpException($message, $previous); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is not exactly the same. TheController class doesn't throw the exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh, indeed. what a weird method anyways. will fix
fixed the comments. and thanks@timglabisch! credit goes to@sixty-nine, he started this ages ago and i said i would do a PR with it, but never got around to do it until now. |
| $templating->renderResponse($view, $parameters, $response); | ||
| :method:`Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller::renderViev` (service: ``templating``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Typo : maybe change torenderView :)
thanks@Pierstoval , updated the things you noted. |
Thanks@dbu! This looks really good to me. |
This PR was merged into the 2.3 branch.Discussion----------adding table for controller as a service| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes| Applies to | all| Fixed tickets | -an old thing from my todo list. talked with@beberlei about this at some point. he had a couple of interesting blog posts about this topic but i can't find it anymore. and afaik the symfony doc does not want this kind of external links anyways.Commits-------b17f422 use definition list instead of table8e82db4 adding table for controller as a service
When I merge to 2.6, I'll properly change the service ids and variable names
* 2.3: [#5033] Tweaking variable name to "match" the service id [#5017] Minor language tweaks use definition list instead of table adding table for controller as a service Suggested ConEmu in addition to ANSICON to solve the Windows coloring limitation Minor rewording Reworded the note about Windows console and output coloring Update routing.rst Minor rewording add a note about apc for php recent versions Removed a wrong link to a included file Rewording Minor rewording Fixed an internal link Added a note about data transformers not being applied with inherit_data option set Added a commented config useful when you use symlinks Minor rewording Added a note about the class option of the services defined via factories Added a note about the server_version DBAL optionConflicts:components/dependency_injection/factories.rst
* 2.6: (91 commits) [#5064] Minor language tweaks Fixing bad merge conflict (forgot to save!) Remove unnecessary component reference Correct RegisterListenersPass namespace Fix service id Switched the first example to a static constructor method added some more components for Tobion as a merger Fixed variable name in : Reference -> validation constraints -> count -> basic usage -> PHP [#5036] Typo fix (probably mine originally) caught by xabbuh reword to serves Adding a link to define "lts" Better wording Minor improvement for symfony-installer with LTS Updating for new security service names in 2.6 [#5033] Tweaking variable name to "match" the service id [#5017] Minor language tweaks [#5015] Updating the security service name for 2.6 - thanks to Cordoval [#5015] Very small tweak [#5011] Adding one more fix I missed [#5011] Fixing minor build issue ...Conflicts:book/security.rst
* 2.7: (103 commits) Backporting some stuff from 2.7, that I think must have gotten merged only there by accident [#5064] Minor language tweaks Fixing bad merge conflict (forgot to save!) Remove unnecessary component reference Correct RegisterListenersPass namespace Fix service id Switched the first example to a static constructor method added some more components for Tobion as a merger Fixed variable name in : Reference -> validation constraints -> count -> basic usage -> PHP [#5036] Typo fix (probably mine originally) caught by xabbuh reword to serves Adding a link to define "lts" Better wording Minor improvement for symfony-installer with LTS Updating for new security service names in 2.6 [#5033] Tweaking variable name to "match" the service id [#5017] Minor language tweaks [#5015] Updating the security service name for 2.6 - thanks to Cordoval [#5015] Very small tweak [#5011] Adding one more fix I missed ...
an old thing from my todo list. talked with@beberlei about this at some point. he had a couple of interesting blog posts about this topic but i can't find it anymore. and afaik the symfony doc does not want this kind of external links anyways.