Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Added a brief explanation about Doctrine DBAL Session Storage#5019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
i am not sure of the comma here
wouterj commentedFeb 19, 2015
There was already a PR on this:#3914 We should pick the best things of both PRs and have one PR. |
javiereguiluz commentedFeb 19, 2015
@wouterj I'm sorry about that. Can we develop a bot that automatically applies the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note that these paragraphs are true for 2.3, but not for 2.6+ (the DBAL session storage has not been migrated to implement session locking yet AFAIK)
javiereguiluz commentedJun 23, 2015
Closing it because there is another previous PR to fix this issue. |
javiereguiluz commentedJun 26, 2015
Reopening it because the other previous PR was closed precisely in favor of this PR. |
javiereguiluz commentedJul 15, 2015
What's left for this PR to be considered finished? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The other examples don't have thepdo. prefix.
weaverryan commentedOct 15, 2015
I actually dislike that we're giving people two equivalent options (or maybe this is not as good as the PDO option, since it doesn't have the new locking stuff). I'd like tonot document this - since it doesn't add anything, it takes away. Also, the biggest potential advantage - reusing the dbal connection - is not a good idea, according to the original PR:symfony/symfony#2182 (comment) Anyone else agree? |
stof commentedOct 15, 2015
the DBAL implementation made sense in 2.3 because it allowed to lazy-load the connection. but the new 2.6+ PDO implementation also supports lazy-loading the PDO connection, so it is indeed less necessary. |
weaverryan commentedOct 15, 2015
Thanks Stof - I'm going to leave this as a "will not document" |
This PR fixes one of the oldest pending issues, dating back to Nov. 2011 :)