Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Code style standardization on form type options#4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@mimol91
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets~

I m not quite sure how to set proper name for bool attributes.
I read on SF Code standards "For type-hinting in PHPDocs and casting, use bool (instead of boolean or Boolean)", however I change it to boolean. (Most commonly used)

@mimol91mimol91force-pushed theform-type-standardization branch 2 times, most recently from70a4484 toc06967cCompareFebruary 6, 2015 20:43
@mimol91mimol91force-pushed theform-type-standardization branch fromc06967c tob37314bCompareFebruary 6, 2015 20:48
@wouterj
Copy link
Member

Thank you for the work you've done. However, I think most of these changes are covered by#4956 and#4671 Can you please remove all changes that are also in one of those 2 PRs, so we're left with only the remaining issues?

@mimol91
Copy link
ContributorAuthor

Is there any git command to remove this changes if there are on other commits?
I would rather not want to do it manually.
It is not any problem for me to wait until PR#4956#4671 will be merged

@wouterj
Copy link
Member

Yes, that's fine by me

@mimol91
Copy link
ContributorAuthor

@wouterj
Hello. I merged changes.
Please let me know if it is OK

@xabbuh
Copy link
Member

👍 looks great

@wouterj
Copy link
Member

Hi@mimol91! Thanks for your work and taking care of updating this PR. Something still went wrong while trying to merge it, so I started a new branch and cherry-picked you commit. This resulted in a new PR:#5365 (you're still the author of the commit). I'll merge that PR, so I'll close this PR.

Thanks again!

@wouterjwouterj closed thisJun 7, 2015
wouterj added a commit that referenced this pull requestJun 7, 2015
…ions (mimol91)This PR was merged into the 2.3 branch.Discussion----------Finish#4967: Code style standardization on form type optionsCloses#4967Commits-------b389f03 code style standardization on form type options
@mimol91
Copy link
ContributorAuthor

@wouterj
Thanks. Good Job

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mimol91@wouterj@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp