Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Removed no longer needed information about PHP 5.3#4854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think you can also remove the comma in front of the "and".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not entirely sure about this one. I think it's valid here to difference that this list is not "A, B or C", but instead "A, B or C, and D".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's see what@weaverryan thinks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
my "gut feeling" is that I agree with Wouter - it helps give the sentence some separation/pause. Is "gut feeling" good enough? ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
fair enough :)
weaverryan commentedFeb 24, 2015
Yep, very very good idea. Not all things we say need to be there forever - it's cool how "new" things become commonplace. Thanks! |
This PR was merged into the 2.3 branch.Discussion----------Removed no longer needed information about PHP 5.3While merging,#4753, I thought we could remove these things completely from the docs, as PHP 5.3 and namespacing are quite common now.| Q | A| --- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | -Commits-------b6636ae Removed no longer needed information about PHP 5.3
While merging,#4753, I thought we could remove these things completely from the docs, as PHP 5.3 and namespacing are quite common now.