Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Add meaning of yellow icon for number of queries#4842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| If you make more than 50 queries on a page, the icon will turn yellow to | ||
| let you know that you are making a lot of requests to the database. This | ||
| is only a warning and does not have any effect on the execution of further | ||
| queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is only a warning, but it means there is potentially an issue in your page (N+1 requests because of proxy initialization in a loop for instance). The warning is here for a reason. Such number of queries is often an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes. Are you saying here we should tell the user more aggressively that they should keep the number of queries below 50?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
well, they should be careful if it goes higher (especially if it happens often). Note that 50 is quite arbitrary here. Blackfire may turn the corresponding metric into red on a different threshold for instance.
the general rule is that lots of DB queries is a bad sign for perf (because DB queries take time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like the clarifiation, but I think it's a bit too long. What do you think about:
The icon will turn yellow if there were more than 50 queries on the page, this could indicate that something is not correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure, sounds great to me. I was mainly concerned with getting the information about the yellow icon in there.
@XitasoChris Can you apply the change suggested by@wouterj? |
@xabbuh Done, sorry for the delay. |
@XitasoChris Thanks 👍 |
This is a great PR - something wasn't clear, so you've cleared it up for others. Thanks so much for this @XitasoChris! |
…oChris)This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes#4842).Discussion----------Add meaning of yellow icon for number of queriesSome people (me included) have been confused about why the number of queries is sometimes displayed in a yellow color. Added explanation for this.Number is fromhttps://stackoverflow.com/questions/17859176/what-does-the-yellow-color-warning-icon-mean-in-symfony2-web-profilerCommits-------5e687b2 changes as suggested by WouterJ in pull request#48425ce0f3d Add meaning of yellow icon for number of queries
* 2.3: (44 commits) Removed duplicate "long"s terminate file with newline move title back and move description to separate file as suggested in PR#4892 move title out of included file as suggested in PR#4892 Add possible values for widget_type [#4842] Making 2 sentences changes as suggested by WouterJ in pull request#4842 Add meaning of yellow icon for number of queries Fixing bad link name fix typo in event flow diagrams Many fixes thanks to stof, WouterJ, xabbuh and dupuchba added Jakub as a merger for the DomCrawler component [#5094] Removing mkdir - it's not needed (thanks xabbuh) some tweaks to#4601 Moving index down to correct section [#4989] Language tweaks and making the example simpler Remove useless setLocale() call and add code block with locale setter Finaly touches on translation locale setting note Review note about setting the translator locale in a controller. Update translation.rst ...Conflicts:cookbook/security/entity_provider.rst
* 2.6: (45 commits) Removed duplicate "long"s terminate file with newline move title back and move description to separate file as suggested in PR#4892 move title out of included file as suggested in PR#4892 Add possible values for widget_type [#4842] Making 2 sentences changes as suggested by WouterJ in pull request#4842 Add meaning of yellow icon for number of queries Fixing bad link name fix typo in event flow diagrams Many fixes thanks to stof, WouterJ, xabbuh and dupuchba added Jakub as a merger for the DomCrawler component [#5094] Removing mkdir - it's not needed (thanks xabbuh) some tweaks to#4601 Moving index down to correct section [#4989] Language tweaks and making the example simpler Remove useless setLocale() call and add code block with locale setter Finaly touches on translation locale setting note Review note about setting the translator locale in a controller. Update translation.rst ...
* 2.7: (47 commits) Removed duplicate "long"s terminate file with newline move title back and move description to separate file as suggested in PR#4892 move title out of included file as suggested in PR#4892 Add possible values for widget_type [#4842] Making 2 sentences changes as suggested by WouterJ in pull request#4842 Add meaning of yellow icon for number of queries Fixing bad link name fix typo in event flow diagrams Many fixes thanks to stof, WouterJ, xabbuh and dupuchba added Jakub as a merger for the DomCrawler component Changes thanks to WouterJ and xabbuh [#5094] Removing mkdir - it's not needed (thanks xabbuh) some tweaks to#4601 Moving index down to correct section [#4989] Language tweaks and making the example simpler Remove useless setLocale() call and add code block with locale setter Finaly touches on translation locale setting note Review note about setting the translator locale in a controller. ...
Some people (me included) have been confused about why the number of queries is sometimes displayed in a yellow color. Added explanation for this.
Number is fromhttps://stackoverflow.com/questions/17859176/what-does-the-yellow-color-warning-icon-mean-in-symfony2-web-profiler