symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

Add dateinterval type reference#4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

wouterj merged 1 commit intosymfony:masterfromMisatoTremor:add_dateinterval_doc

Nov 10, 2016

Merged

Add dateinterval type reference#4817

wouterj merged 1 commit intosymfony:masterfromMisatoTremor:add_dateinterval_doc

Nov 10, 2016

Conversation

Copy link

Contributor

MisatoTremor commentedJan 13, 2015•
edited
Loading

Q	A
Doc fix?	no
New docs?	yes
Applies to	3.2
Fixed tickets	#4816

MisatoTremor mentioned this pull request

Jan 13, 2015

[Form][FrameworkBundle][Bridge] Add a DateInterval form typesymfony/symfony#13390

Closed

xabbuh added Status: Needs Work On hold labels

Jan 13, 2015

xabbuh reviewed

Jan 13, 2015

View reviewed changes

reference/forms/types/dateinterval.rst Outdated

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would use the "simple" table syntax:

==============  ===========  ======================================Variable        Type         Usage==============  ===========  ======================================``widget``      ``mixed``    The value of the `widget`_ option.``with_years``  ``boolean``  The value of the `with_years`_ option.and             so           on==============  ===========  ======================================

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done

Copy link

ContributorAuthor

MisatoTremor commentedJan 14, 2015

Changed it like@javiereguiluz said.
I only swapped the two RFC duration strings, putting the shorter (and hopefully easier to understand) one in the intro text and the full example in the string input description.
Also fixed the sorting of the options list to match the other type docs.

MisatoTremor mentioned this pull request

Jun 18, 2015

[Form][FrameworkBundle][Bridge] Add a DateInterval form typesymfony/symfony#15030

Closed

MisatoTremor mentioned this pull request

Dec 2, 2015

[Form][FrameworkBundle][Bridge] Add a DateInterval form typesymfony/symfony#16809

Merged

xabbuh added this to the3.2 milestone

May 21, 2016

fabpot added a commit to symfony/symfony that referenced this pull request

Jun 22, 2016

feature#16809[Form][FrameworkBundle][Bridge] Add a DateInterval for…

1298ce5

…m type (MisatoTremor)This PR was merged into the 3.2-dev branch.Discussion----------[Form][FrameworkBundle][Bridge] Add a DateInterval form type| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#13389| License       | MIT| Doc PR        |symfony/symfony-docs#4817Replaces#15030Commits-------f7669be [Form] Add a DateInterval form type Also add dateinterval widget to twig templates.

Copy link

Contributor

HeahDude commentedJun 22, 2016

symfony/symfony#16809 (comment) is merged now, can a maintainer please remove "On hold" label?

@MisatoTremor What the status here?

MisatoTremor force-pushed theadd_dateinterval_doc branch from32e42c2 to1883265Compare

June 22, 2016 14:32

Copy link

ContributorAuthor

MisatoTremor commentedJun 22, 2016

@HeahDude
Updated for 3.2

xabbuh removed the On hold label

Jun 23, 2016

xabbuh changed the title~~[WCM] Add dateinterval type reference~~Add dateinterval type reference

Jun 23, 2016

xabbuh reviewed

Jun 23, 2016

View reviewed changes

reference/forms/types/dateinterval.rst Outdated

		\| Options \| - `days`_ \|
		\| \| - `placeholder`_ \|
		\| \| - `hours`_ \|
		\| \| - `input`_ \|

Copy link

Member

xabbuhJun 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks like something went wrong here

Copy link

ContributorAuthor

MisatoTremorJun 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removed read_only field reference, build now runs successfully.

@xabbuh What do you mean with this line comment?

Copy link

Member

xabbuhJun 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@MisatoTremor When I reviewed this earlier today the diff looked completely broken. Looks like this was related to my browser then or the issue disappeared with your push. So everything's fine here how. :)

MisatoTremor force-pushed theadd_dateinterval_doc branch from1883265 tof9128eeCompare

June 23, 2016 15:30

wouterj reviewed

Jul 2, 2016

View reviewed changes

reference/forms/types/dateinterval.rst Outdated


		DateIntervalType Field Type
		===========================

Copy link

Member

wouterjJul 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

missing a versionadded directive:

..versionadded::3.2   The DateIntervalType field type was introduced in Symfony 3.2.

Copy link

ContributorAuthor

MisatoTremorJul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Added

Copy link

Member

wouterj commentedJul 2, 2016

👍 Thanks for writing the documentation for the feature@MisatoTremor!

status: reviewed

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Jul 2, 2016

javiereguiluz reviewed

Jul 4, 2016

View reviewed changes

reference/forms/types/dateinterval.rst Outdated

		date interval. It can be rendered as a integer or text input or select tags.

		The underlying format of the data can be a ``DateInterval`` object,
		a `RFC 3339`_ duration string (e.g. ``P1DT12H``) or an array.

Copy link

Member

javiereguiluzJul 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are we sure we want to link to the RFC 3339? In that RFC you can read the following:

It looks like we should link instead to ISO 8601 standard:https://en.wikipedia.org/wiki/ISO_8601

Copy link

Member

javiereguiluz commentedJul 4, 2016

@MisatoTremor thanks for adding this form type and for providing the docs too. Today we've highlighted it in the Symfony blog (seeNew in Symfony 3.2: DateInterval form type).

When writing the blog post, I wondered if this type could be a bit easier to use. In particular, I wonder if theinput option could be removed. If it's only used to tell the form type which format we are using (DateInterval, array or string) I think we can detect the format automatically. Do you think that would be possible? Thanks!

MisatoTremor force-pushed theadd_dateinterval_doc branch fromf9128ee to6ed9ed7Compare

July 4, 2016 10:18

Copy link

ContributorAuthor

MisatoTremor commentedJul 4, 2016

@javiereguiluz Thanks for the nice highlight! :)

I've included the option according to other date/time types, but this indeed sounds like a great improvement. Maybe this could be done for the other types, too. Will look into into

weaverryan reviewed

Jul 10, 2016

View reviewed changes

reference/forms/types/dateinterval.rst Outdated

		options are ``input`` and ``widget``.

		Suppose that you have a ``remindEvery`` field whose underlying interval is a
		``DateInterval`` object. The following configures the ``dateinterval`` type

Copy link

Member

weaverryanJul 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

... configures the ``DateIntervalType``

Copy link

Member

weaverryan commentedJul 10, 2016

Thanks for the work@MisatoTremor - it's a really interesting component! And I'm sorry, I just peppered you with comments :)

Status: Needs Work

carsonbot added Status: Needs Work and removed Status: Reviewed labels

Jul 10, 2016

MisatoTremor force-pushed theadd_dateinterval_doc branch from6ed9ed7 to2c5b539Compare

July 29, 2016 16:11

Add dateinterval type reference

3d55585

MisatoTremor force-pushed theadd_dateinterval_doc branch from2c5b539 to3d55585Compare

July 29, 2016 16:15

Copy link

ContributorAuthor

MisatoTremor commentedJul 29, 2016

@weaverryan Thank for your review Ryan. I applied all but one which I commented upon.

Copy link

Member

wouterj commentedNov 8, 2016

Hi@MisatoTremor! I'm sorry for the long delay, seems like this one slipped under our radar. As 3 doc members already reviewed this and you fixed their comments, I assume this one is ready to merge.

/cc @symfony/team-symfony-docs

status: reviewed

carsonbot added Status: Reviewed and removed Status: Needs Work labels

Nov 8, 2016

Copy link

Member

javiereguiluz commentedNov 8, 2016

👍 this is indeed ready to be merged. Thanks@MisatoTremor.

Copy link

ContributorAuthor

MisatoTremor commentedNov 9, 2016

@wouterj I totally understand this. :) There's much to do and also more important sections. You all are doing a great job!

Thanks for the update.

Copy link

Member

wouterj commentedNov 10, 2016

Thanks Steffen for your work & patience! This is now merged in the docs and will be online tomorrow.

wouterj merged commit3d55585 intosymfony:master

Nov 10, 2016

wouterj added a commit that referenced this pull request

Nov 10, 2016

feature#4817Add dateinterval type reference (MisatoTremor)

b8cda8d

This PR was merged into the master branch.Discussion----------Add dateinterval type reference| Q | A || --- | --- || Doc fix? | no || New docs? | yes || Applies to | 3.2 || Fixed tickets |#4816 |Commits-------3d55585 Add dateinterval type reference

MisatoTremor deleted the add_dateinterval_doc branch

November 22, 2016 09:30

Labels

Status: Reviewed

		\| Options \| - `days`_ \|
		\| \| - `placeholder`_ \|
		\| \| - `hours`_ \|
		\| \| - `input`_ \|

Movatterモバイル変換

Uh oh!

Add dateinterval type reference#4817

Add dateinterval type reference#4817

Uh oh!

Conversation

MisatoTremor commentedJan 13, 2015• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MisatoTremor commentedJan 14, 2015

Uh oh!

HeahDude commentedJun 22, 2016

Uh oh!

MisatoTremor commentedJun 22, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wouterj commentedJul 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

javiereguiluz commentedJul 4, 2016

Uh oh!

MisatoTremor commentedJul 4, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weaverryan commentedJul 10, 2016

Uh oh!

MisatoTremor commentedJul 29, 2016

Uh oh!

wouterj commentedNov 8, 2016

Uh oh!

javiereguiluz commentedNov 8, 2016

Uh oh!

MisatoTremor commentedNov 9, 2016

Uh oh!

wouterj commentedNov 10, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MisatoTremor commentedJan 13, 2015•
edited
Loading