Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Update validation.rst#4789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3| Fixed tickets | Some fixes can be a bit "controversial".Due to PRhttps://github.com/symfony/symfony-docs/pull/4779/files not all changes were made.Something to keep in mind is what due tohttps://github.com/symfony/symfony-docs/pull/4779/files using `Assert\...` if arguments are kept on the same line the possibility of horizontal scrollbar (especially on the smaller screens) is quite high.Also for most use cases I think adding PHP constraints is better if arguments are on different lines ("easier to read" and easier to spot errors
ifdattic commentedJan 7, 2015
I would like to split line 344 to remove horizontal scrollbar, but wasn't sure of the best way to do it |
book/validation.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While it's not your fault, you should remove the serial comma before "or"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yea, I thought it wasn't needed but just left it as is, will fix on the next commit.
wouterj commentedJan 7, 2015
|
ifdattic commentedJan 7, 2015
Yes, thank you, completely slipped my mind that is how you do in YAML |
book/validation.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You need to add the former label to be BC:
.. _translation-constraint-messages:Translating Constraint Messages-------------------------------
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, will change it now
xabbuh commentedMay 23, 2015
What do we do here? |
wouterj commentedMay 23, 2015
Closing as none of the code blocks are violating the 85 character limit we've decided on after this PR was opened (only the schema definitions do, but we don't care about them). The only other change in here is implementing UserInterface, which is already done. |
Some fixes can be a bit "controversial".
Due to PRhttps://github.com/symfony/symfony-docs/pull/4779/files not all changes were made.
Something to keep in mind is what due tohttps://github.com/symfony/symfony-docs/pull/4779/files using
Assert\...if arguments are kept on the same line the possibility of horizontal scrollbar (especially on the smaller screens) is quite high.Also for most use cases I think adding PHP constraints is better if arguments are on different lines ("easier to read" and easier to spot errors