Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Tweaks to the new form csrf caching entry#4772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dbu commentedJan 5, 2015
seems good to me, easier to read and no mistakes introduced as far as i can see. |
cookbook/cache/form_csrf_caching.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think there are some missing words here:
When a user submits, the token ...Proposal:
When a user submits the form, the token ...This PR was merged into the 2.3 branch.Discussion----------Tweaks to the new form csrf caching entry| Q | A| ------------- | ---| Doc fix? | no| New docs? | no| Applies to | all| Fixed tickets | n/aHi guys!After merging this nice new entry in#4141, I wanted to make a few minor language tweaks (the diff looks bigger than the changes really are). This included shortening a few sections and talking less about how *all* reverse proxies refuse to cache pages with a session, because I don't (for example) believe this is true with Symfony's reverse proxy.Thanks!Commits-------cc40b5c Adding missing words thanks to javiereguiluz1c568e1 [#4141] Tweaks to the new form csrf caching entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't it be "is" instead of "are"? And should we add a label for the old headline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're right! Fixed at sha:36d1bac
Hi guys!
After merging this nice new entry in#4141, I wanted to make a few minor language tweaks (the diff looks bigger than the changes really are). This included shortening a few sections and talking less about howall reverse proxies refuse to cache pages with a session, because I don't (for example) believe this is true with Symfony's reverse proxy.
Thanks!