To explain: I think we should start with a clean docs in 3.0, only adding changes of 3.0.

@wouterj I agree 100% with you! This is a great idea!

👍

👍 We just need to be aware do this again when new features are documented on the2.x branches (we have pending pull requests for2.6 and there will very likely new features in2.7).

This is indeed a good idea, but I think that everytime we remove a versionadded directive, we also should remove the old way. If you merge this PR as is, it will be much more difficult to this afterwards.

If you take for instance thereference/twig_reference.rst file, you removed the following directive:

.. versionadded:: 2.6     The ``app.security`` global is deprecated as of 2.6. The user is already available     as ``app.user`` and ``is_granted()`` is registered as function.

It's very clear that all references toapp.security must be removed from the docs or replaced by the better alternatives. But without this directives, it's much harder to know what is obsolete and what is not. In this specific case, it's quite simple as it's about removing the docs forapp.security, but it can be more subtle elsewhere.

That a great point I didn't think about. If I'm correct, we have always removed old behaviour, but I'll check it again and open other PRs to fix them. Until that's done, I label this as on hold.

@wouterj Yes, usually we did. Last weekend I checked the pull request on the code repository that removed deprecated features in the 3.0 branch and we already covered most of them. There were only a few things left and we now have pull requests for them.

Closing in favor of#5585