Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Use AppBundle whenever it's possible#4740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
👍 |
@javiereguiluz Great work! 👍 |
WOW, this is a massive amount of work - thanks so much Javier! It's also a big leap of faith - I can see all the changes, but if we're missing anything, we can't see those. But it seems like you were quite careful - I see you catching web/bundles/* symlink names, service names and more. And there's no way we can be more sure than this. So, I'm merging this in and we'll keep moving from here. Yay! |
This PR was merged into the 2.3 branch.Discussion----------Use AppBundle whenever it's possible| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3+| Fixed tickets | -This PR replaces `AcmeFooBundle`, `AcmeHelloBundle` and `AcmeDemoBundle` by `AppBundle` whenever it's possible in the Cookbook.This is the first step into making the cookbook compliant with the recent good practices promoted by Symfony (the book is being made compliant in#4431). If we change everything to comply with the good practices, the pull request will be massive and it will take months. That's why I think it's better to do it in several steps using different pull requests.By the way, this PR also contains some minor tweaks about using the new `app/config/services.yml` file. I can revert those changes if you want it.Commits-------c6580f8 Use AppBundle whenever it's possible
This brings the class names back in sync after the change in PRsymfony#4740.
This PR replaces
AcmeFooBundle,AcmeHelloBundleandAcmeDemoBundlebyAppBundlewhenever it's possible in the Cookbook.This is the first step into making the cookbook compliant with the recent good practices promoted by Symfony (the book is being made compliant in#4431). If we change everything to comply with the good practices, the pull request will be massive and it will take months. That's why I think it's better to do it in several steps using different pull requests.
By the way, this PR also contains some minor tweaks about using the new
app/config/services.ymlfile. I can revert those changes if you want it.