Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Mention @Security() annotation instead of @Secure()#4733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Mention @Security() annotation instead of @Secure()#4733
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJan 2, 2015
I think we should simply merge this into the By the way, you would have to revert the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is not true technically. Other features of SensioFrameworkExtraBundle 3.0 can be used in Symfony 2.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I copied this note from this other note:
The @Security annotation was introduced in SensioFrameworkExtraBundle 3.0. This bundle version can only be used with Symfony 2.4 or later (see the SensioFrameworkExtraBundle release cycle).Source:http://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/security.html
Should we also fix the original note?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As I saidhere, we shouldn't over-complicate things here. Even the bundle's readme just states "The minimum version of Symfony2 for this workflow is 2.4.0.".
The `@Security` annotation was introduced in SensioFrameworkExtraBundle3.0 which requires Symfony 2.4 or higher.This change has to be reverted in the `2.5` branch once it got mergedup.
| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.5| Fixed tickets |
| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.5| Fixed tickets |
| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3| Fixed tickets |
| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.6| Fixed tickets |
The class loader is located in the Debug component and not in theClassLoader component.
This PR was merged into the 2.5 branch.Discussion----------[Book][Validation] clarify group validation| Q | A| ------------- | ---| Doc fix? | no| New docs? | no| Applies to | 2.5+| Fixed tickets | part ofsymfony#4094This is for item `F` ofsymfony#4094. Actually, we didn't have anything wrong as long as I didn't miss anything. I only made two little changes to fix a sentence and clarify the legacy API.Commits-------1c79cad clarify group validation
This PR was merged into the 2.6 branch.Discussion----------Update templating.rst| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.6| Fixed tickets |Commits-------851be38 Update templating.rst
This PR was merged into the 2.6 branch.Discussion----------Fix markupversionadded directives are quite strange, as it doesn't allow to have empty lines in it. So both code blocks were rendered as a blockquote (using shortcut) and PHP code for the main text (using code-block directive). This fixes it and also fixes some other markup errors.Commits-------ab66a12 Fix markup
This PR was merged into the 2.3 branch.Discussion----------[Cookbook][Routing] Fixed typo| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3+| Fixed tickets |Commits-------0a60deb [Cookbook][Routing] Fixed typo
Displaying the message of an `AuthenticationException` might exposesensitive data to the user.
Conflicts:changelog.rst
Conflicts:changelog.rst
…book (javiereguiluz)This PR was merged into the 2.3 branch.Discussion----------Removed the Stable API chapter from the Symfony book| Q | A| ------------- | ---| Doc fix? | no| New docs? | no| Applies to | all| Fixed tickets | -The two main reasons for this change are: 1) the traffic to that book chapter is almost zero; 2) all the things explained in this "chapter" are better explained in the BC Promise article. A redirection to that article has been setup.Commits-------42269d4 Removed the Stable API chapter from the Symfony book
… in PHP templates (javiereguiluz)This PR was merged into the 2.3 branch.Discussion----------Added a reference about including JS and CSS files in PHP templates| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes| Applies to | all| Fixed tickets |symfony#4836Commits-------5c6d4b2 Fixed a minor RST syntax issue4d472c2 Added a reference about including JS and CSS files in PHP templates
| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.4| Fixed tickets |
This PR was submitted for the 2.4 branch but it was merged into the 2.5 branch instead (closessymfony#4928).Discussion----------Change installation method order| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.4| Fixed tickets |Commits-------1db39c2 Update introduction.rst475be21 Change installation method order
…s a little different)
* 2.3: [symfony#4928] Backporting change after merging into 2.5 (since 2.3 is a little different) Fixed a minor RST syntax issue Added a reference about including JS and CSS files in PHP templates Removed the Stable API chapter from the Symfony bookConflicts:book/stable_api.rstcomponents/debug/introduction.rst
…ractices (ifdattic)This PR was merged into the 2.3 branch.Discussion----------Remove block which doesn't make sense after best practices| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3| Fixed tickets |Commits-------26415e2 Remove block which doesn't make sense after best practices
* 2.3: Add missing comma in array Fix typos Remove block which doesn't make sense after best practices
* 2.5: [symfony#4928] Backporting change after merging into 2.5 (since 2.3 is a little different) Update introduction.rst Change installation method order Add missing comma in array Fix typos Remove block which doesn't make sense after best practices Fixed a minor RST syntax issue Added a reference about including JS and CSS files in PHP templates Removed the Stable API chapter from the Symfony book
javiereguiluz commentedFeb 2, 2015
@xabbuh is there anything else left to be done in this PR before consider itfinished? Thanks. |
xabbuh commentedFeb 2, 2015
@javiereguiluz Given that 2.5 has reached the end of maintenance in the meantime, I think you can put back the 2.6 related changes. So this can then be merged into the |
javiereguiluz commentedFeb 2, 2015
@xabbuh I've done what you said, so this PR is ready for the final review. Thanks. |
xabbuh commentedFeb 2, 2015
👍 |
wouterj commentedFeb 3, 2015
@javiereguiluz could you please rebase this PR against 2.6? GH has lots of trouble with our submodules when switching form an unmaintained branch (2.4) to a maintained one. |
17ee9e8 to6e273b8Compare6e273b8 to99163edComparejaviereguiluz commentedFeb 3, 2015
Closed this pull request in favor of#4957 |
Beware that (if accepted) this PR must be merged in 2.4+ because
@Securityisn't available in Symfony 2.3.