Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Book][Testing] bump required PHPUnit version#4731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedJan 2, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
| @@ -17,7 +17,7 @@ it has its own excellent `documentation`_. | |||
| .. note:: | |||
| Symfony works with PHPUnit 3.5.11 or later, though version3.6.4 is | |||
| Symfony works with PHPUnit 3.5.11 or later, though version4.2 is | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we really still talk about PHPUnit 3.5.11 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Actually, I'm not sure we can still run our testsuite on 3.5.11. I'm actually quite sure we started using 3.6+ features a long time ago, and we probably even use some newer features in a few place. So the requirement version should be bumped.
And the recommendation should be to use the latest stable version IMO (because this is what we actually use on Travis and on our development boxes, and so this is what actually works for sure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IIRC the testsuite usesatLeastOnce() which requires 4.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I updated the wording.
3dd5877 toc5d4ce1CompareThanks! |
This PR was merged into the 2.3 branch.Discussion----------[Book][Testing] bump required PHPUnit version| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |Commits-------c5d4ce1 bump required PHPUnit version