Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Reference] add validation config reference section#4673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.3fromxabbuh:issue-4094-reference
Dec 29, 2014

Conversation

@xabbuh
Copy link
Member

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets

@xabbuhxabbuhforce-pushed theissue-4094-reference branch 3 times, most recently from2b38a28 to88df04aCompareDecember 20, 2014 23:02
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, Ryan. I'll remove it here and add it again when creating the pull request for theapi option.

@weaverryan
Copy link
Member

I left a few comments, but nice catch on this being missing! It looks like several other options are introduced in 2.5 (and maybe also 2.6) - including the very-important api version for 2.5.

Thanks!

@xabbuh
Copy link
MemberAuthor

I left a few comments, but nice catch on this being missing! It looks like several other options are introduced in 2.5 (and maybe also 2.6) - including the very-important api version for 2.5.

Honestly, I just caught this when I wanted to document theapi option and then decided to add the whole section first.

@xabbuh
Copy link
MemberAuthor

I moved the2.5 specific parts into a new pull request (see#4682).

@weaverryan
Copy link
Member

Thanks for the quick work! Now I'll go check the other PR :)

@weaverryanweaverryan merged commit79ad3b5 intosymfony:2.3Dec 29, 2014
weaverryan added a commit that referenced this pull requestDec 29, 2014
…bbuh)This PR was merged into the 2.3 branch.Discussion----------[Reference] add validation config reference section| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets |Commits-------79ad3b5 add validation config reference section
@xabbuhxabbuh deleted the issue-4094-reference branchDecember 29, 2014 18:38
@xabbuhxabbuh mentioned this pull requestDec 29, 2014
wouterj added a commit that referenced this pull requestDec 31, 2014
This PR was merged into the 2.3 branch.Discussion----------[Reference] fix wording| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets |#4673Commits-------10b06da [Reference] fix wording
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xabbuh@weaverryan@wouterj
[8]ページ先頭
©2009-2025 Movatter.jp