Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
consistent spelling#4671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
consistent spelling#4671
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedDec 19, 2014
Q | A |
---|---|
Doc fix? | no |
New docs? | no |
Applies to | all |
Fixed tickets | #3237 |
- stylesheet - Stylesheet
- front-end - frontend - front end
- Full-Stack - Full stack
- Symfony2 Framework - form framework - Form framework
- Save-handler - Save handler
- Dependeny Injection Tags - Dependeny Injection Container - dependeny injection container
- Event Dispatcher - event dispatcher
- Event Subscriber - event subscriber
- Symfony2 Standard Distribution - Symfony2 Standard Edition
- Console Command - console command
- email - Email - e-mail
- Boolean - boolean
- web debug toolbar - Web Debug Toolbar
- Exception - exception
- object-oriented - object oriented
@@ -13,7 +13,7 @@ Component. Configuration values are usually expected to show some kind of | |||
hierarchy. Also, values should be of a certain type, be restricted in number | |||
or be one of a given set of values. For example, the following configuration | |||
(in YAML) shows a clear hierarchy and some validation rules that should be | |||
applied to it (like: "the value for ``auto_connect`` must be aboolean value"): | |||
applied to it (like: "the value for ``auto_connect`` must be aBoolean value"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should the adjective have a capital letter too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
At least, that's how Wikipedia uses it (I also think that this make sense since it's based on George Boole's name).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this should be reverted to lowercase, just like the rest of the occurences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hmm, there are more Boolean occurences. Looks like you didn't replace them to be lowercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
still goes wrong here,@xabbuh (seems like all "boolean" occurences are replaced with "Boolean" and all "Boolean" with "boolean")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Agreed - the PR has a mix of changes right now. irrc, we've started using the lowercase version in core, but I'm not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
core has switched tobool
to support Hack. I'm still voting for "boolean"
Do we really want Boolean? I really don't like it as it's inconsistent. |
@wouterj I think it make sense in terms that it is derived from George Boole's name. We also used By the way, why do we use |
d906731
toc09ba41
CompareSeems we have a majority for |
@xabbuh the code changed this year to I don't think bool is as clear as boolean, that's why I propose to keep using boolean instead of bool |
@wouterj Thanks for the explanation. So, should we now keep lowercased |
I think we should use |
This is ready to be reviewed now. I've kept different commits for each item of the task list so that you can review each step on its own. However, there are two changes I'm not completely happy with:
|
@xabbuh regarding your questions:
Do you think this PR could be merged anytime soon? It looks like we're very close thanks to your great work and it's sad to see these nice improvements pending to be merged. Thanks. |
@javiereguiluz This can be merged once we agree on all the changes. :) Though I'm fine with splitting it in several PRs if there are some things that should be discussed while others may be settled. @wouterj@weaverryan What do you think? |
+1 for Symfony Full-Stack Framework Btw, thsi also needs a rebase. |
@@ -1519,7 +1519,7 @@ file, you can see every block needed to render a form and every default field | |||
type. | |||
In PHP, the fragments are individual template files. By default they are located in | |||
the `Resources/views/Form` directory of theframework bundle (`view on GitHub`_). | |||
the `Resources/views/Form` directory of theFrameworkBundle (`view on GitHub`_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this should be double backticks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we do this anywhere else with bundle names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sorry, I meant theresoruces/views/form
at the start of the line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, of course. Totally missed that. Thanks for noticing. 👍
This PR still contains the boolean mix up. |
24eba9c
tof0e0663
CompareI rebased and finally fixed the boolean/Boolean mix up. |
Let's merge this one to avoid more conflicts :) |
WOW@xabbuh. And not even any conflicts :). Thanks for the long work on this! |
This PR was merged into the 2.3 branch.Discussion----------consistent spelling| Q | A| ------------- | ---| Doc fix? | no| New docs? | no| Applies to | all| Fixed tickets |#3237- [x] stylesheet - Stylesheet- [x] front-end - frontend - front end- [x] Full-Stack - Full stack- [x] Symfony2 Framework - form framework - Form framework- [x] Save-handler - Save handler- [x] Dependeny Injection Tags - Dependeny Injection Container - dependeny injection container- [x] Event Dispatcher - event dispatcher- [x] Event Subscriber - event subscriber- [x] Symfony2 Standard Distribution - Symfony2 Standard Edition- [x] Console Command - console command- [x] email - Email - e-mail- [x] Boolean - boolean- [x] web debug toolbar - Web Debug Toolbar- [x] Exception - exception- [x] object-oriented - object orientedCommits-------f182121 uppercase "dependency injection"6b7d536 use "Symfony Framework" instead of "Symfony framework"07bc4db use "Form component" instead of "form framework"bd5ca26 use "full-stack" instead of "full stack"5b6895a unify exception usagesb774651 unify event subscriber usages95c842c use "console command" instead of "Console Command"9c02eda unify EventDispatcher/event dispatcher usagesfd52cd3 use boolean instead of Booleanf8db4b0 use "object-oriented" instead of "object oriented"1bd33ca "web debug toolbar" instead of "Web Debug Toolbar"b2d802e use "stylesheet" instead of "Stylesheet"7eb1847 unify "Symfony Standard Edition" usages85fb0b1 consistency, replace "save-handler" with "save handler"83238aa consisteny, use "front-end" instead of "frontend" or "front end"5b8e84d consistency, replace "e-mail" with "email"