Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Rewritten from scratch the chapter about installing Symfony#4654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Rewritten from scratch the chapter about installing Symfony#4654
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedDec 15, 2014
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes |
| Applies to | all |
| Fixed tickets | #4122,#4089 |
book/installation.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The sentenceIn that case, read the next Creating Symfony Applications without the Installer section looks weird IMO
to move symfony.phar to projects directory
book/installation.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would change this sentence to this ("the" is missing, theref label is not needed and "know" doesn't seem to be the right word to me):
Read the:ref:`book-creating-applications-without-the-installer` section to learn how to proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Your proposal is much better. Thanks!
xabbuh commentedDec 17, 2014
Looks great, Javier! 👍 |
weaverryan commentedDec 20, 2014
Thank god for this - I will review shortly (I just ran out of time right now). I don't think that the plans I laid out in#4672 nullify this, I actually think this will be a major step forwardtowards that. |
…fony (javiereguiluz)This PR was merged into the 2.3 branch.Discussion----------Rewritten from scratch the chapter about installing Symfony| Q | A| ------------- | ---| Doc fix? | yes| New docs? | yes| Applies to | all| Fixed tickets |#4122,#4089Commits-------7de83a3 Replaced a "note" by a "seealso"b45c338 Imrpoved the wording of the note about using using legacy PHP 5.3 version40d7772 Reworded the reasons why you should use Composer-based installation2e72138 Wrapped a line to follow doc standards7e9cd04 Display the same version number on Linux and Windows to avoid confusions12c2557 Add an explicit command to better explain that we recommend to move symfony.phar to projects directory12eb76e Reworded a confusing phraseb665d86 Added a note about verifying Symfony digital signatures8f202c6 Re-added a wrongly deleted link referencec291a73 Rewritten from scratch the chapter about installing Symfony
weaverryan commentedDec 21, 2014
Thanks so much Javier! When I created my list for#4672, this was - by far - the ugliest and worst todo on that list. I think we can take another look at it once the new download page is there, but it's already many times better than before. Cheers! |