Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

How to override vendor directory location#4643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 3 commits intosymfony:2.3fromgajdaw:override-vendor-directory-location
Jan 16, 2015
Merged

How to override vendor directory location#4643

weaverryan merged 3 commits intosymfony:2.3fromgajdaw:override-vendor-directory-location
Jan 16, 2015

Conversation

@gajdaw
Copy link
Contributor

QA
Doc fix?[no]
New docs?[no]
Applies to[Symfony 2.3]
Fixed tickets[#4642]

@gajdaw
Copy link
ContributorAuthor

@wouterj I have created a new PR and closed the previous one#4642.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It seems to me that you break lines too early. It's sufficient to add a newline after the first word that crosses the 72nd character (same below).

@gajdaw
Copy link
ContributorAuthor

@xabbuh I have reformatted the commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we really need the docblock here?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@xabbuh You are right. This is completely unnecessary.

@xabbuh
Copy link
Member

@gajdaw Looks good to me. I just left a last comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

now you just need to remove this empty line and everything is ok. Thanks for your quick action each time!

@timglabisch
Copy link
Contributor

shoulnd this contributed to composers documentation and just linked?

@gajdaw
Copy link
ContributorAuthor

@timglabisch Because of the change inapp/autoload.php I think Symfony docs is the right place for it.

Composer's doc contains info aboutvendor-dir inhttps://getcomposer.org/doc/04-schema.md

@gajdaw
Copy link
ContributorAuthor

@wouterj@xabbuh : done.

@gajdaw
Copy link
ContributorAuthor

@wouterj I think its finished.

@weaverryan
Copy link
Member

Very nice - thanks Włodzimierz!

@weaverryanweaverryan merged commit0875bd8 intosymfony:2.3Jan 16, 2015
weaverryan added a commit that referenced this pull requestJan 16, 2015
This PR was merged into the 2.3 branch.Discussion----------How to override vendor directory location| Q             | A| ------------- | ---| Doc fix?      | [no]| New docs?     | [no]| Applies to    | [Symfony 2.3]| Fixed tickets | [#4642]Commits-------0875bd8 How to override vendor directory location - fix07f6843 How to override vendor directory location - fixbce4c16 How to override vendor directory location
weaverryan added a commit that referenced this pull requestJan 16, 2015
weaverryan added a commit that referenced this pull requestJan 16, 2015
* 2.3:  [#4857] Adding missing word thanks to xabbuh  Fixing bad english thanks to xabbuh  Adding missing words thanks to javiereguiluz  [#4643] Minor english changes to make things even smoother (though they were correct before)  replace API link for SwiftmailerBundle  Update security.rst  Update routing.rst  don't output message from AuthenticationException  Add custom link labels where Cookbook articles titles looked wrong  Removed a leftover comma in security config sample  [#4141] Tweaks to the new form csrf caching entry  How to override vendor directory location - fix  How to override vendor directory location - fix  How to override vendor directory location
weaverryan added a commit that referenced this pull requestJan 16, 2015
* 2.5:  [#4857] Adding missing word thanks to xabbuh  Fixing bad english thanks to xabbuh  Adding missing words thanks to javiereguiluz  [#4643] Minor english changes to make things even smoother (though they were correct before)  replace API link for SwiftmailerBundle  Update security.rst  Update routing.rst  don't output message from AuthenticationException  Add custom link labels where Cookbook articles titles looked wrong  Fix code example  Removed a leftover comma in security config sample  [#4141] Tweaks to the new form csrf caching entry  How to override vendor directory location - fix  How to override vendor directory location - fix  How to override vendor directory location
weaverryan added a commit that referenced this pull requestJan 18, 2015
* 2.6: (30 commits)  fix merge after removing @Security in 2.3  Reverting a commit on 2.5 branch, as it was only meant to be on 2.3 (so reverting after the merge)  [#4735] Reverting what was left on the 2.5 branch after the merge conflict had already put back some of it  Typo Fix: "allows to" should be "allows you to"  Adding a link to log things in the prod environment  [#4857] Adding missing word thanks to xabbuh  move cautions to make them visible  Fixing bad english thanks to xabbuh  Adding missing words thanks to javiereguiluz  language tweak thanks to xabbuh!  Adding an example image of the debug_formatter  [#4643] Minor english changes to make things even smoother (though they were correct before)  replace API link for SwiftmailerBundle  Update security.rst  Update routing.rst  don't output message from AuthenticationException  Add custom link labels where Cookbook articles titles looked wrong  Fix typo: BLOG => BLOB  Fix code example  Removed a leftover comma in security config sample  ...Conflicts:reference/configuration/security.rst
weaverryan added a commit that referenced this pull requestJan 18, 2015
* 2.7: (31 commits)  fix merge after removing @Security in 2.3  Reverting a commit on 2.5 branch, as it was only meant to be on 2.3 (so reverting after the merge)  [#4735] Reverting what was left on the 2.5 branch after the merge conflict had already put back some of it  Typo Fix: "allows to" should be "allows you to"  Adding a link to log things in the prod environment  [#4857] Adding missing word thanks to xabbuh  move cautions to make them visible  Fixing bad english thanks to xabbuh  Adding missing words thanks to javiereguiluz  language tweak thanks to xabbuh!  Adding an example image of the debug_formatter  [#4643] Minor english changes to make things even smoother (though they were correct before)  replace API link for SwiftmailerBundle  Update security.rst  Update routing.rst  don't output message from AuthenticationException  Add custom link labels where Cookbook articles titles looked wrong  Fix typo: BLOG => BLOB  Fix code example  Removed a leftover comma in security config sample  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gajdaw@xabbuh@timglabisch@weaverryan@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp