Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
How to override vendor directory location#4642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…te Helper is (iltar)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#4344).Discussion----------[Templating] Added a sentence that explains what a Template Helper is| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | n/aI found a SecurityHelper in the SecurityBundle. I was unsure what this helper was or what it was supposed to do. After some googling I've landed on the templating component documation. This is correct as the `HelperInterface` can be found in [the component](http://symfony.com/doc/current/components/templating/introduction.html#helpers). However, it doesn't explain what a helper is.After some searching, [the cookbook *does* explain what a helper is](http://symfony.com/doc/current/cookbook/templating/PHP.html#using-template-helpers). I've pretty much copied over the sentence from the cookbook to the component. If you have a better proposal, I can add that instead.Commits-------6cdecde [Templating] Added a sentence that explains what a Template Helper is
…on paragraphs (arnaugm)This PR was merged into the 2.3 branch.Discussion----------Remove incoherence between Doctrine and Propel introduction paragraphs| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |#4349The introductory paragraph of Doctrine and Propel sections, although both are true in some way, look contradictory, so a rephrase of at least one of the two paragraphs would be convenient.Commits-------7992fdf Remove incoherence between Doctrine and Propel introduction paragraphs
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#4388).Discussion----------Minor spelling fixhttp://www.oxforddictionaries.com/definition/english/groundCommits-------ef3a58e Minor spelling fix
This re-adds PR#4280, which was temporarily reverted while we waitedfor the proper PHP extensions.
…ed forms to Valid... (peterrehm)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#4348).Discussion----------Updated information about handling validation of embedded forms to Valid...| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |#4346Applied Valid constraint instead of the cascade_validation option since this option is supposed to be deprecated withsymfony/symfony#12237Commits-------b699731 Updated information about handling validation of embedded forms to Valid constraint
This PR was merged into the 2.3 branch.Discussion----------update Sphinx extension submodule reference| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |Commits-------5ca2df8 update Sphinx extension submodule reference
Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer.This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes#4375).Discussion----------Removed the redundant usage of layer.Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer whereas Doctrine does own the layer and is properly defined in the header.Commits-------27339c7 One more again. I could have sworn I had them lined up.84164fa Removed the possession from Doctrine.693698e Shorten the = to match the length of the text.5ea2902 Removed the redundant usage of layer.
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes#4387).Discussion----------Inline condition removed for easier readingPrevious inline condition would cause confusion or trigger notifications in IDE (Netbeans,...)Commits-------b98f5e8 Inline condition removed for easier reading
It seems like this one was missed when reverting the change. For thediscussion, see#4290
"name" in requirements is confusing, I had problem for doing the same and then after 2 days I found that the "name" should be same as the parameter, it is not part of symfony config requirements: name: .+
Added bcrypt and plaintext encoder
there are references to "--dev" composer parameter that is thecurrent default value.
…nit tests, (carlosbuenosvinos)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#4585).Discussion----------When explaining how to install dependencies for running unit tests,| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |#4584Commits-------512632e When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value.
| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |
This PR was merged into the 2.3 branch.Discussion----------Change refering block name from content to body| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |Commits-------5c0ceff Change refering block name from content to body
Currently all of the titles in Console section use gerund, but not this one.
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes#4625).Discussion----------Added '-ing' title ending to unify titles lookCurrently all of the titles in Console section use gerund, but not this one.Commits-------74b75de Added '-ing' title ending to unify titles look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this should be a double colon.
gajdaw commentedDec 13, 2014
Hi WouterJ, |
wouterj commentedDec 13, 2014
It looks great! Thanks for your quick response,@gajdaw! Now we just have to wait till@weaverryan hits the merge button. |
wouterj commentedDec 13, 2014
Btw, can you please rebase on 2.3. 2.0, 2.1 and 2.2 are no longer maintained. |
gajdaw commentedDec 13, 2014
I have just rebased it against 2.3 branch. But I cannot change the destination branch in pull request. |
This PR was merged into the 2.3 branch.Discussion----------How to override vendor directory location| Q | A| ------------- | ---| Doc fix? | [no]| New docs? | [no]| Applies to | [Symfony 2.3]| Fixed tickets | [#4642]Commits-------0875bd8 How to override vendor directory location - fix07f6843 How to override vendor directory location - fixbce4c16 How to override vendor directory location
Hi,
I have found this solution extremely efficient when working on Vagrant/Windows.
Maybe others will find it interesting too.
I have tested it in Symfony 2.3 only, so I am not sure if it applies to all other versions.