Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added '-ing' title ending to unify titles look#4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
kix wants to merge1 commit intosymfony:2.6fromkix:patch-2

Conversation

kix
Copy link
Contributor

@kixkix commentedDec 11, 2014

Currently all of the titles in Console section use gerund, but not this one.

@xabbuh
Copy link
Member

👍 Why not? Consistency is always nice in the docs.

@kix We need however take into account that someone might already refer to the old headline. Therefore we should add a label to keep the old anchor working. Can you please add one just before the headline? It would basically then look like this ("are" should actually be capitalised too):

.. _understand-how-console-arguments-are-handled:Understanding how Console Arguments Are Handled===============================================

Currently all of the titles in Console section use gerund, but not this one.
@kix
Copy link
ContributorAuthor

kix commentedDec 11, 2014

@xabbuh, 👍

@xabbuh
Copy link
Member

Thanks@kix

weaverryan added a commit that referenced this pull requestDec 11, 2014
* 2.3:  [#4625] Removing link added for BC, because this is the top of the page anyways  Added '-ing' title ending to unify titles look  [OptionsResolver] Fix Namespace link  filesystem headlines match method names  Change refering block name from content to body  When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value.  Fixing missing services key  readd mistakenly removed label  fix feature freeze datesConflicts:best_practices/security.rst
weaverryan added a commit that referenced this pull requestDec 11, 2014
* 2.5:  [#4625] Removing link added for BC, because this is the top of the page anyways  Added '-ing' title ending to unify titles look  [OptionsResolver] Fix Namespace link  filesystem headlines match method names  Change refering block name from content to body  When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value.  Fixing missing services key  readd mistakenly removed label  fix feature freeze datesConflicts:components/options_resolver.rst
weaverryan added a commit that referenced this pull requestDec 11, 2014
* 2.7:  [#4625] Removing link added for BC, because this is the top of the page anyways  Added '-ing' title ending to unify titles look  [OptionsResolver] Fix namespace  [OptionsResolver] Fix Namespace link  filesystem headlines match method names  Change refering block name from content to body  Update pdo_session_storage.rst  When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value.  Fixing missing services key  readd mistakenly removed label  fix feature freeze dates
@weaverryan
Copy link
Member

I love it - thanks Stepan!

@xabbuh you're to think about think about the "BC" on the anchor of course, but in this case, we're at the top of the page anyways, so I don't we need to worry about it. I removed it at sha:7b16d3b

Thanks!

@xabbuh
Copy link
Member

@weaverryan That's true for now. But what if we decide to move that section further down in the future?

@weaverryan
Copy link
Member

That seems unlikely - it's the title of the whole article :). Probably, if you linked to it, you really mean to just link to the whole article.

@kixkix deleted the patch-2 branchDecember 12, 2014 06:52
@wouterj
Copy link
Member

Btw, the title doesn't even have a link anchor next to it. So it isn't obvious for people to know that you can reference the title.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@kix@xabbuh@weaverryan@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp