When explaining how to install dependencies for running unit tests,#4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

carlosbuenosvinos wants to merge1 commit intosymfony:masterfromcarlosbuenosvinos:improve_running_tests_chapter

Closed

When explaining how to install dependencies for running unit tests,#4585

carlosbuenosvinos wants to merge1 commit intosymfony:masterfromcarlosbuenosvinos:improve_running_tests_chapter

Conversation

Copy link

Contributor

carlosbuenosvinos commentedDec 3, 2014

Q	A
Doc fix?	yes
New docs?	no
Applies to	all
Fixed tickets	#4584

When explaining how to install dependencies for running unit tests,

21bf13e

there are references to "--dev" composer parameter that is thecurrent default value.

Copy link

Contributor

timglabisch commentedDec 3, 2014

👍

Copy link

Member

xabbuh commentedDec 3, 2014

Good idea@carlosbuenosvinos. Is this the only file where we use Composer with the--dev flag?

Copy link

ContributorAuthor

carlosbuenosvinos commentedDec 4, 2014

It's the only one.

2014-12-04 0:02 GMT+01:00 Christian Flothmannnotifications@github.com:

Good idea@carlosbuenosvinos https://github.com/carlosbuenosvinos. Is
this the only file where we use Composer with the --dev flag?
—
Reply to this email directly or view it on GitHub
#4585 (comment).

Carlos Buenosvinos Zamora
carlos.buenosvinos@gmail.com
659730605

url:http://carlosbuenosvinos.com
twitter: buenosvinos
skype: carlos.buenosvinos
gtalk:carlos.buenosvinos@gmail.com

xabbuh added the Status: Reviewed label

Dec 4, 2014

Copy link

Member

weaverryan commentedDec 7, 2014

Why should we make this change? I'm sure there's a good reason - I just don't know what it is :)

Thanks!

Copy link

Member

@weaverryan The--dev option is simply not needed since it is the default (it has changed a while ago in Composer). If we kept it in the documentation, people might get the feeling that--no-dev was the default.

wouterj added a commit that referenced this pull request

Dec 8, 2014

minor#4585When explaining how to install dependencies for running u…

7dcce1b

…nit tests, (carlosbuenosvinos)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#4585).Discussion----------When explaining how to install dependencies for running unit tests,| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets |#4584Commits-------512632e When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value.