Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[Hackday] Update Heroku doc with SYMFONY_ENV param#4545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mxnr commentedNov 29, 2014
| Q | A |
|---|---|
| Doc fix? | [yes] |
| New docs? | [no] |
| Applies to | [2.5, 2.6, 2.7] |
| Fixed tickets | #4217 |
This resolves#4217, right? |
It looks like that, thanks@xabbuh! I update description. |
| .. code-block:: yaml | ||
| "post-install-cmd": [ | ||
| "Incenteev\\ParameterHandler\\ScriptHandler::buildParameters", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is it really a good idea to show the complete content of the composer.json here?
this will become bad if we have to maintain this for different versions. i would prefer something like:
make sure you removed: ....
make sure you added: ....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would indeed prefer to use... to fold some irrelevant things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is no longer necessary, the underlying issue is now fixed in Symfony.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this section should then be removed from this PR to avoid confusion
Just realized my#4591 is a duplicate of this. |