Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Deploy Symfony application on Platform.sh.#4526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Once your project is ready, give it a name and choose: **Create a new site**. | ||
| Choose the *Symfony* stack and a starting point such as *Standard*. | ||
| That's it! Your Symfony application will be bootstaped and deployed. You'll soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
bootstaped -> bootstrapped
👍 |
@pborreli Thanks ! |
| .. _`Platform.sh documentation`: https://docs.platform.sh/toolstacks/symfony/symfony-getting-started | ||
| .. _`Platform.sh project`: https://marketplace.commerceguys.com/platform/buy-now | ||
| .. _`Platform.sh configuration files`: https://docs.platform.sh/reference/configuration-files | ||
| .. _`Github`: https://github.com/platformsh/platformsh-examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
minor: Github -> GitHub
| $container->setParameter('database_path', ''); | ||
| } | ||
| # Hack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
remove the "#Hack" comment or find a solution :)
@GuGuss Nice addition! I have left some minor comments. |
Thanks guys for the review. |
This should make the Travis build pass.
| To deploy your Symfony application on Platform.sh, you simply need to add a | ||
| ``.platform.app.yaml`` at the root of your Git repository which will tell | ||
| Platform.sh how to deploy your application (read more about `Platform.sh | ||
| configuration files`_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we're used to put roles on the same line. So could you add a linebreak before ``Platform.sh configuration files_ please?
| .. code-block:: yaml | ||
| # .platform.app.yaml | ||
| # This file describes an application. You can have multiple applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
standards state that there should be an empty line between a file comment and a normal comment.
Thanks again guys for your review. I think this is ready to go ^^ |
Hi guys, any update on this PR? |
@GuGuss You also have to add a reference to the new document in After that, I think this is ready to be merged. Really nice document! 👍 |
Done ! Thanks guys ! |
👍 |
I'm trusting that all the specs and details are there, but I think that's ok since this is coming straight from you guys@GuGuss :). This reads really well - I'm happy to merge it in. Thanks! |
No description provided.