Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Deploy Symfony application on Platform.sh.#4526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cookbook/deployment/platformsh.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
bootstaped -> bootstrapped
pborreli commentedNov 28, 2014
👍 |
GuGuss commentedNov 28, 2014
@pborreli Thanks ! |
cookbook/deployment/platformsh.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
minor: Github -> GitHub
cookbook/deployment/platformsh.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
remove the "#Hack" comment or find a solution :)
xabbuh commentedNov 28, 2014
@GuGuss Nice addition! I have left some minor comments. |
GuGuss commentedNov 29, 2014
Thanks guys for the review. |
This should make the Travis build pass.
cookbook/deployment/platformsh.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we're used to put roles on the same line. So could you add a linebreak before ``Platform.sh configuration files_ please?
cookbook/deployment/platformsh.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
standards state that there should be an empty line between a file comment and a normal comment.
GuGuss commentedDec 9, 2014
Thanks again guys for your review. I think this is ready to go ^^ |
GuGuss commentedDec 15, 2014
Hi guys, any update on this PR? |
javiereguiluz commentedDec 19, 2014
xabbuh commentedDec 19, 2014
@GuGuss You also have to add a reference to the new document in After that, I think this is ready to be merged. Really nice document! 👍 |
GuGuss commentedDec 24, 2014
Done ! Thanks guys ! |
xabbuh commentedDec 24, 2014
👍 |
weaverryan commentedDec 26, 2014
I'm trusting that all the specs and details are there, but I think that's ok since this is coming straight from you guys@GuGuss :). This reads really well - I'm happy to merge it in. Thanks! |
No description provided.