Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Replacing deprecated security context#4512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The `Symfony\Component\Security\Core\SecurityContextInterface` was deprecatedwith symfony 2.6. All instances of this interface where replaced with`Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface`or`Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface`depending on the use case.All instances of `SecurityContext` where replaced as well.This was done based on the blog posthttp://symfony.com/blog/new-in-symfony-2-6-security-component-improvements
I think that there is a minor error in the PR number showed in the "Fixed tickets" row. Instead of 5411, your probably wanted to display 4511. |
@javiereguiluz Yes, thanks for noticing. Updated! |
@Sgoettschkes you're going to hate me ... but I think there is again an error in the "Fixed tickets" PR number. Now it shows 4512 and you probably wanted to display 4511. |
@javiereguiluz Not at all. It's my fault after all. Sorry for the confusion. Checked the link, it should be ok now. |
@Sgoettschkes everything is perfect now. Thanks! |
@Sgoettschkes Thank you for your pull request. Though I think that this is already covered by#4188 which completely covers the split of the |
@Sgoettschkes It's indeed a good idea to check if nothing is missing in#4188 that is covered by your changes. 👍 |
@Sgoettschkes I think I've covered the most important things, I suggest you to forkmy branch and see if there's still anything missing. I won't do any --force anymore, so you can safely use it. |
| { | ||
| $this->securityContext = $securityContext; | ||
| $this-$tokenStorage = $tokenStorage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typo here
Closing here.@Sgoettschkes feel free to ping us if you notice anything that was not covered by#4188. |
This PR turned out larger than wanted. I wasn't able to test all changes, but as stated inhttp://symfony.com/blog/new-in-symfony-2-6-security-component-improvements replacing should work without problems.