Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[BestPractices Removing micro-optimization note about @Template#4464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -76,20 +76,15 @@ Template Configuration | ||
Don't use the ``@Template()`` annotation to configure the template used by | ||
the controller. | ||
The ``@Template`` annotation is useful, but also involves some magic. We | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. You avoided the first person perspective in the rest of the Best Practices, didn't you? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Actually, this is one spot where we use it liberally - as in "we recommend..." | ||
don't think its benefit is worth the magic, and so recommend against using | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. isn't this comma an Oxford comma? | ||
it. | ||
Most of the time, ``@Template`` is used without any parameters, which makes | ||
it more difficult to know which template is being rendered. It also makes | ||
it less obvious to beginners that a controller should always return a Response | ||
object (unless you're using a view layer). | ||
How the Controller Looks | ||
------------------------ | ||