I think that a small performance gain is not agreat reason to recommend something. And really, this was not the most important reason for recommending against@Template. I think it's clearer to focus on the real reason, and not get into performance (we could argue against using any feature because of performance).

Thanks!

Removing micro-optimization note about@template

5d36409

Copy link

Member

javiereguiluz commentedNov 14, 2014

One of the (few) great things about@Template() is that it takes into account the format of the request to determine the template to render. Should we add a note about this or is not that important?

xabbuh reviewed

Nov 14, 2014

View reviewed changes

best_practices/controllers.rst

		@@ -76,20 +76,15 @@ Template Configuration
		Don't use the ``@Template()`` annotation to configure the template used by
		the controller.

		The ``@Template`` annotation is useful, but also involves some magic. For
		that reason, we don't recommend using it.
		The ``@Template`` annotation is useful, but also involves some magic. We

Copy link

Member

xabbuhNov 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You avoided the first person perspective in the rest of the Best Practices, didn't you?

Copy link

MemberAuthor

weaverryanNov 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actually, this is one spot where we use it liberally - as in "we recommend..."

wouterj added the Status: Needs Work label

Nov 16, 2014

Copy link

MemberAuthor

weaverryan commentedNov 18, 2014

@javiereguiluz I've never understood the point of the guessing of the template suffix, but it sounds like you may have a use-case. For me, I would never use a template to print JSON or XML, so I've never found this useful. Is there some good case for this?