Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

consistent table headlines#4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 2 commits intosymfony:2.3fromxabbuh:table-headlines
Nov 13, 2014
Merged

Conversation

@xabbuh
Copy link
Member

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets

@wouterj
Copy link
Member

👍 Cool. you're always blazing fast on these things!

@xabbuh
Copy link
MemberAuthor

Otherwise I would forget them. ;)

@javiereguiluz
Copy link
Member

@xabbuh thanks for working on this!

I have a comment about the new table syntax. Inthis table, columns are separated with two white spaces, while in the rest of the tables you use one white space.

Instead of suggesting you to use also one white space on the first table, I'd like to ask you reconsider using always two white spaces. That's what I've been using and I think that it improves readability.

@xabbuh
Copy link
MemberAuthor

@javiereguiluz There was no specific reason. Honestly, I simply didn't realise that there already were two spaces. Personally, I don't really care if we use one space or two spaces.

@wouterj@weaverryan What are your thoughts on this?

@wouterj
Copy link
Member

+1 for 2 spaces

Op di 11 nov. 2014 18:33 schreef Christian Flothmann <
notifications@github.com>:

@javiereguiluzhttps://github.com/javiereguiluz There was no specific
reason. Honestly, I simply didn't realise that there already were two
spaces. Personally, I don't really care if we use one space or two spaces.

@wouterjhttps://github.com/WouterJ@weaverryan
https://github.com/weaverryan What are your thoughts on this?


Reply to this email directly or view it on GitHub
#4435 (comment).

@weaverryan
Copy link
Member

If both render ok, I'm also cool with 2 spaces - I guess the extra separation makes it a bit more readable in the source.

@xabbuh
Copy link
MemberAuthor

Alright, do we wanna do that in this pull request or do you prefer a different one?

@weaverryan
Copy link
Member

@xabbuh This one if it's ok - it'll save me from merging up twice, which may involve a few conflicts :).

@xabbuh
Copy link
MemberAuthor

Of course, no problem. Here we go.

@weaverryanweaverryan merged commit10b607b intosymfony:2.3Nov 13, 2014
weaverryan added a commit that referenced this pull requestNov 13, 2014
This PR was merged into the 2.3 branch.Discussion----------consistent table headlines| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets |Commits-------10b607b separate table columns with two spaces178a2d6 consistent table headlines
@weaverryan
Copy link
Member

@xabbuh, beautiful - merged in and merged up to master!

@xabbuhxabbuh deleted the table-headlines branchNovember 13, 2014 20:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@wouterj@javiereguiluz@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp