Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Documented the new label_format option#4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
javiereguiluz wants to merge5 commits intosymfony:masterfromjaviereguiluz:add_label_format_option
Closed

Documented the new label_format option#4412

javiereguiluz wants to merge5 commits intosymfony:masterfromjaviereguiluz:add_label_format_option

Conversation

@javiereguiluz
Copy link
Member

QA
Doc fix?no
New docs?yes
Applies to2.6+
Fixed tickets#4286

@xabbuh
Copy link
Member

@javiereguiluz The new file is missing the.inc filename suffix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[...] isthe "humanized" [...]

_exts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

is it intended to change the sphinx-php extension version ?

@javiereguiluz
Copy link
MemberAuthor

I've fixed the technical problems reported by@xabbuh and@stof. Now you can review its contents and decide if it's worth it to add it to the Symfony documentation. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

could you please add a short explaination for name and id? (name = name of the field, id = name of each parent field + name of the field).

@wouterj
Copy link
Member

ping@javiereguiluz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

what is the default value? we should provide this info?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the default value of the option isnull, which will then trigger the generation of the label based on the form name

@ubermuda
Copy link

Maybe there should be a note that this feature is actually implemented in the template and that it won't work if your form theme does not support it?

@stof
Copy link
Member

stof commentedJan 2, 2015

this is a good idea indeed. People using a custom type should be aware they might need to update it.

@wouterj
Copy link
Member

ping@javiereguiluz

@wouterj
Copy link
Member

Hi@javiereguiluz! Do you maybe have some time to update this, or should I put it on the list for the sprint day?

@javiereguiluz
Copy link
MemberAuthor

@wouterj sadly I'm not motivated to finish this PR, so please put it on the list. Thanks!

@wouterj
Copy link
Member

Closing in favor of#5642

wouterj added a commit that referenced this pull requestFeb 6, 2016
This PR was merged into the 2.7 branch.Discussion----------Documented label_format option| Q   | A| --- | ---| Doc fix? | no| New docs? | yes (symfony/symfony#12050)| Applies to | 2.6+| Fixed tickets |#4286@javiereguiluz abandoned#4412, so I continued#4489. I welcome any improvements, as I'm not 100% sure this is well documented now.Commits-------ac0fdbc Documented label_format option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@javiereguiluz@xabbuh@wouterj@ubermuda@stof@timglabisch

[8]ページ先頭

©2009-2025 Movatter.jp