Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Inline condition removed for easier reading#4387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Previous inline condition would cause confusion or trigger notifications in IDE (Netbeans,...)
cookbook/doctrine/file_uploads.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here you have to use an assignment but no comparison operator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(sorry, I made that typo too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
haha we'll get it right soon !
acidjames commentedOct 29, 2014
Hi i see that i referenced this PR from a commit, is that enough for it to be merged ? sorry i'm new ... |
wouterj commentedOct 29, 2014
@acidjames you should put the required changes in the branch that is related to this PR: The PR can only be merged by people with push access (basically@weaverryan and me). I'll merge your PR once you did the required changed. Btw, if you need more help, don't hesitate to ask :) |
acidjames commentedOct 30, 2014
@wouterj i've been trying to access acidjames:patch-1 with the official Github client without success, should i be using this client or something else ? |
wouterj commentedOct 30, 2014
@acidjames you can go tohttp://github.com/acidjames/symfony-docs/tree/patch-1 Then navigate to the file and click on "edit", make the changes and commit them. |
cookbook/doctrine/file_uploads.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The+ has to be removed.
acidjames commentedOct 31, 2014
Sorry guys, i'll do better next time i promise ! |
wouterj commentedOct 31, 2014
No worries, we are here to help you. You did a great job, thanks! |
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes#4387).Discussion----------Inline condition removed for easier readingPrevious inline condition would cause confusion or trigger notifications in IDE (Netbeans,...)Commits-------b98f5e8 Inline condition removed for easier reading
Previous inline condition would cause confusion or trigger notifications in IDE (Netbeans,...)