Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updated Valid constraint reference#4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 1 commit intosymfony:2.3frominso:patch-2
Oct 29, 2014
Merged

Conversation

@inso
Copy link

QA
Doc fix?yes
New docs?no
Applies to2.3
Fixed tickets

Revised PR#4351 for 2.3 branch

@wouterj
Copy link
Member

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe we can reword this a bit. For example:

If this constraint is enabled on a property that holds an array, each element in that array will be validated recursively.

What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is wrong, this sentence is about optiondeep.
Constraint can beapplied to property, but not enabled and optiondeep can beenabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, you're right. I should have written it like this:

If the constraint is applied on a property that holds an array and thedeep option is enabled, each element in that array will be validated recursively.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've used the same wording as used for optiontraverse.
Personally I also don't like that sentence, and I think that description of both options should be changed (in separate PR?).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi guys!

I've merged this in because it has some nice fixes and is at least 90% of the way there. So, let's talk about the wording here.

As I understand it (just from reading what we have here), these 2 options (traverse anddeep) applyonly if this is applied to a collection of objects. Is that correct?

Now, even though I can see the wording difference betweentraverse anddeep, I don't really understand yet what the difference is. Doestraverse mean "validate the objects" anddeep means "validate the objects AND validate any objects embedded in those objects"?. Or does it mean something else? Does it make sense to set bothtraverse anddeep to true at the same time, or is this redundant?

As you can see, I don't know yet exactly how this feature works. What I think we should do is include these in the main "Basic Usage" section so people can really see how they work and how they work together. This may mean we have a new sub-section called something like "Validating a collection of items".

What do you guys think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm actually not sure what they do. Maybe@webmozart can shed some light on it.

@weaverryan
Copy link
Member

Great fixes - thanks@inso! I'll comment separately about the wording dicussions :).

@weaverryanweaverryan merged commita50bb96 intosymfony:2.3Oct 29, 2014
weaverryan added a commit that referenced this pull requestOct 29, 2014
This PR was merged into the 2.3 branch.Discussion----------Updated Valid constraint reference| Q              | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | 2.3| Fixed tickets |Revised PR#4351 for 2.3 branchCommits-------a50bb96 Updated Valid constraint reference
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@inso@wouterj@weaverryan@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp