Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Removed the redundant usage of layer.#4375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer.cookbook/doctrine/dbal.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please shorten the underline to match the length of the headline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and it should be "Doctrine DBAL" now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@wouterj I can make the change, but I'm curious if you can explain your line of thinking a bit more so I can understand what you are looking for.
The reason I'm leaving Doctrine as possessive of the DBAL is that in the document, it is explained that the ORM component of Doctrine is a higher level of the DBAL. So Doctrine owns multiple components, making it possessive of the DBAL. That's my reasoning at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Of course :)
The database abstraction layer created by Doctrine is called "Doctrine DBAL", just like the object relation mapper is called "Doctrine ORM". While it's also the DBAL of the Doctrine Project, it's official name is "Doctrine DBAL". That's why I want to use "Doctrine DBAL" instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works for me. Changing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@wouterj Changed.
xabbuh commentedOct 25, 2014
@micheal These are only little details, but they matter as well. 👍 |
h4ckninja commentedOct 25, 2014
@xabbuh Done. :) |
wouterj commentedOct 26, 2014
Thanks! |
cookbook/doctrine/dbal.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need to remove 2== so that it has the same length as the title. Yep, this actually matters :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed, I hope. I could have sworn I had things fixed properly already.
weaverryan commentedOct 30, 2014
Great, thanks so much@micheal! |
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes#4375).Discussion----------Removed the redundant usage of layer.Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer whereas Doctrine does own the layer and is properly defined in the header.Commits-------27339c7 One more again. I could have sworn I had them lined up.84164fa Removed the possession from Doctrine.693698e Shorten the = to match the length of the text.5ea2902 Removed the redundant usage of layer.
Since DBAL is database abstraction layer, and is defined in the document as such, to me it reads funny to have it as database abstraction layer layer. It sounds nitpicky, I know, but I find it an easier read this way. Also, the possessive DBAL stuck out ("DBAL's layer") as the DBAL doesn't own a layer, it is the layer whereas Doctrine does own the layer and is properly defined in the header.