Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updated information about handling validation of embedded forms to Valid...#4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
peterrehm wants to merge1 commit intosymfony:masterfrompeterrehm:embedded-forms
Closed

Conversation

@peterrehm
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies toall
Fixed tickets#4346

Applied Valid constraint instead of the cascade_validation option since this option is supposed to be deprecated withsymfony/symfony#12237

@xabbuh
Copy link
Member

Wow, thanks for taking this up so quickly@peterrehm. What do you think about also adding some note to this option in the form reference?

@peterrehm
Copy link
ContributorAuthor

No problem. I have added this depreciation note into a separate PR since this one can be merged immediately, the other one only aftersymfony/symfony#12237 gots merged.

/cc@webmozart

@xabbuh
Copy link
Member

Thanks for the new PR. However, doesn't it make sense to mention in thecascade_validation section that in most cases, you should better use theValid constraint?

@peterrehm
Copy link
ContributorAuthor

It is mentioned? "Instead, use theValid constraint in your model to cascade validation"

@xabbuh
Copy link
Member

Hm, yeah, but it will then only be shown in the 2.6 version of the documentation. Though, as far as I understand the issue, these implications are also true for older versions, aren't they?

@peterrehm
Copy link
ContributorAuthor

I added the recommendation to both PR's so it will appear in all versions. It was mentioned before but not recommended so I thought best would be to have it in a tip section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's add a link to the section in the book chapter that you just added so people can see an example. What do you think?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there the possibility to link to a specified section or only as follows?

:doc:`Forms </book/forms>`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ah yes, you can use:ref: to point to a specific "spot" (and you add a little_foo-bar-baz in the target spot). We have a few examples lying around in the docs - let me know if I'm being too vague :)

@weaverryan
Copy link
Member

I added one small suggestion. But after that, this has a 👍 from me! Furthermore, I'm very happy to have this clarified - iirc, the cascading worked differently in 2.0, so there was some "baggage" in understanding how this worked and documenting it absolutely correctly.

Thanks!

@peterrehm
Copy link
ContributorAuthor

Just updated it as suggested.

@weaverryan
Copy link
Member

Thanks Peter!

weaverryan added a commit that referenced this pull requestOct 29, 2014
…ed forms to Valid... (peterrehm)This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#4348).Discussion----------Updated information about handling validation of embedded forms to Valid...| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets |#4346Applied Valid constraint instead of the cascade_validation option since this option is supposed to be deprecated withsymfony/symfony#12237Commits-------b699731 Updated information about handling validation of embedded forms to Valid constraint
@peterrehmpeterrehm deleted the embedded-forms branchNovember 2, 2014 19:30
weaverryan added a commit that referenced this pull requestJun 19, 2015
…n constraint (peterrehm)This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes#4354).Discussion----------[WCM] Added depreciation note for the cascade_validation constraint| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | 2.8| Fixed tickets | -This PR was based onsymfony/symfony#12237 and has been updated basedassymfony/symfony#15019.#4348Commits-------22a87b5 Added depreciation note for the cascade_validation constraint and updated position of depreciation notes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peterrehm@xabbuh@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp