Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updating library/bundle install docs to use "require"#4290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…uire (no version) functionality
cookbook/bundles/installation.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
must be changed to_KnpBundles.com
wouterj commentedOct 4, 2014
👎 for the reason I mentioned here:#4267 (comment) |
stof commentedOct 4, 2014
@wouterj this is a case against using |
wouterj commentedOct 4, 2014
@stof indeed. This PR does 2 things:
I'm +1 for (1) and -1 for (2). |
weaverryan commentedOct 18, 2014
Hi guys! I agree with Wouter, so I've re-added the version back on several places. When we're giving people docs on how to use a library, then we should have a version, just in case they come out with a new version that's incompatible with our docs. But in other places, if we're just saying "you can install this library" and provide no other details, then I don't think we need the version there. I've updated the PR to reflect that and am merging it in. Thanks! |
…weaverryan)This PR was merged into the 2.3 branch.Discussion----------Updating library/bundle install docs to use "require"| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3+| Fixed tickets | -As ofcomposer/composer#3906, you can now simply install a library via:```php composer.phar require myname/my-lib```The latest version if chosen for you. I've replaced all mentions of modifying composer.json and running `composer update` with using the `require` command. I think the result is much simpler :).Thanks!Commits-------d7ccbf3 Re-adding one more versionab2a688 [#4290] Re-adding version backa174a2b Fixing bad link1a7c4b9 Updating library/bundle installation docs to use the new composer require (no version) functionality
* 2.3: Putting #pull-request-format anchor link back, which we link to in our contrib notes Re-adding one more version [#4290] Re-adding version back Fixing bad link Updating library/bundle installation docs to use the new composer require (no version) functionalityConflicts:components/dependency_injection/lazy_services.rstcookbook/bundles/installation.rst
* 2.5: Putting #pull-request-format anchor link back, which we link to in our contrib notes Re-adding one more version [#4290] Re-adding version back Fixing bad link Updating library/bundle installation docs to use the new composer require (no version) functionality [#4233][#4094] Making validateValue and validate changes Minor tweaks and a missing location thanks to xabbuh and WouterJ Fixes thanks to@xabbuh Adding a section about keeping BC in a re-usable bundle Adding details about the 2.4 API as comments added a versionadded comment to Callback.rst Update custom_contraint.rst to meet the new 2.5 api Don't use deprecated functions in Callback.rst Update Callback.rst Replace addViolationAt (deprecated) by buildViolation
* Added interlinking between the application bundles best practices and this article (which is about reusable bundles)* Readded the version. It seems like this one was missed when reverting ([ref](#4290))
It seems like this one was missed when reverting the change. For thediscussion, seesymfony#4290
It seems like this one was missed when reverting the change. For thediscussion, seesymfony#4290
As ofcomposer/composer#3906, you can now simply install a library via:
The latest version if chosen for you. I've replaced all mentions of modifying composer.json and running
composer updatewith using therequirecommand. I think the result is much simpler :).Thanks!