Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Components][HttpFoundation] Make a small grammatical adjustment#4276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Components][HttpFoundation] Make a small grammatical adjustment#4276
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The original form of the phrase - «The other option is to specificallychecking if a session has expired after the session is started.» - isnot entirely grammatically correct, as the infinitive form of «to check»shall normally be used, or the gerund form, which is the form used inthis commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm far from native, so I can be completely wrong, but isn't "The other option is to specifically check if a session has expired after the session is started." better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FTR, English is not my native language either.
Actually, yes, as I wrote it in the commit message and PR description, I think both the infinitive form and the gerund form are grammatically correct, and, in this context, either may be used as subject complement (but I might also be wrong).
I guess the infinitive form is a bit more literary (although this is very subjective), which is less suitable in a context of technical documentation, and that's why I chose the gerund form in my commit.
Obviously, I'd be willing to commit again with the infinitive form if it's considered a better fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I tend to agree with@wouterj here. But I'm also no native speaker. So, let's wait for@weaverryan for the final decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yep,@wouterj is right. To be clear, the languageis wrong as it currently is. The best is:
The other option is to specifically check if a session has expired after the session is started.
…ustment (fabschurt)This PR was merged into the 2.3 branch.Discussion----------[Components][HttpFoundation] Make a small grammatical adjustment| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3+| Fixed tickets | n/aThe original form of the phrase - «The other option is to specificallychecking if a session has expired after the session is started.» - isnot entirely grammatically correct, as the infinitive form of «to check»shall normally be used, or the gerund form, which is the form used inthis commit.Commits-------3ad13a1 Make a small grammatical adjustment
weaverryan commentedOct 15, 2014
Thanks Fabien for the report of the bad language! I've merged this in and changed the other word so that things are perfect - see sha:4bada7c Cheers! |
* 2.3: [#4276] Making language correction we agreed on [Cookbook][External Parameters] Enhance description of environment variables Make a small grammatical adjustment
* 2.5: [#4276] Making language correction we agreed on Correct a typo: replace "then" by "the". Correct a typo: remove unnecessary "the" word. Remove horizontal scrollbar and change event name to follow conventions Remove horizontal scrollbar Update choice.rst Improve readability support Varnish in configuration blocks minor#4285 Update security.rst (placid2000) Update security.rst [Cookbook][External Parameters] Enhance description of environment variables Make a small grammatical adjustment
The original form of the phrase - «The other option is to specifically
checking if a session has expired after the session is started.» - is
not entirely grammatically correct, as the infinitive form of «to check»
shall normally be used, or the gerund form, which is the form used in
this commit.