Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
provide node path on configuration#4249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
If you no provide node path in assetic configuration, UglifyCssFilter throw a `RuntimeException: Path to node executable could not be resolved.`
xabbuh commentedSep 18, 2014
Actually, as long as the name of the binary is |
desarrolla2 commentedSep 18, 2014
@xabbuh i was updated the PR as you indicate. In my ubuntu14.04 i was installed node via apt and binary name is nodejs |
cookbook/assetic/uglifyjs.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You should use the name number of- characters as there are characters in the headline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The format that we use for the documentation is very strict for things like the length of the headings underlining. So please, reduce the underneath line length to match the length of the title. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The funny thing is that reST only complain about underlines that are too short.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@xabbuh reST allows longer underlines. Matching the length exactly is a matter of coding standards
desarrolla2 commentedSep 18, 2014
I think that i solved your comments |
javiereguiluz commentedSep 18, 2014
@desarrolla2 thanks for your quick response to the comments and for having created this documentation. I know that you've been a Symfony developer for a long time, but if I'm right, this is your first documentation contribution. If this is true, congratulations! By the way, you mentioned theHow to Contribute to Symfony Documentation guide that we recently updated. If you found something hard to understand or some missing explanation, please feel free to open an issue in this repository. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How about:
If it cannot be found, you can configure its location...
weaverryan commentedSep 18, 2014
I just left a comment, but actually, this looks great to me. So I'm going to merge and change the language myself in that tiny spot. Thanks so much for this! |
This PR was merged into the 2.3 branch.Discussion----------provide node path on configuration| Q | A| ------------- | ---| Doc fix? | yes| New docs? | No| Applies to | all| Fixed tickets |If you no provide node path in assetic configuration, UglifyCssFilter throw a `RuntimeException: Path to node executable could not be resolved.`Commits-------ab3dbef update uglifyjs.rst1a5c0a6 Update uglifyjs.rst1621071 Update uglifyjs.rst2258ac9 provide node path on configuration
* 2.3: [#4249] Tiny tweak to language update uglifyjs.rst Update uglifyjs.rst Update uglifyjs.rst provide node path on configuration
* 2.4: [#4249] Tiny tweak to language update uglifyjs.rst Update uglifyjs.rst Update uglifyjs.rst provide node path on configuration
* 2.5: [#4249] Tiny tweak to language update uglifyjs.rst Update uglifyjs.rst Update uglifyjs.rst provide node path on configuration
If you no provide node path in assetic configuration, UglifyCssFilter throw a
RuntimeException: Path to node executable could not be resolved.