Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Added a note about the side effects of enabling both PHP and Twig#4220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedSep 12, 2014
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | 2.3+ |
| Fixed tickets | #3293 |
cookbook/templating/PHP.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be a bit more precise. They will still work in places where you talk to Twig directly (for instance all places referencing a template from another one)
cookbook/templating/PHP.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
allowed, but [...]
weaverryan commentedSep 16, 2014
Thanks Javier! Weird side-effect/bug - I don't really like it. But this is an edge-case for users, so I think it's ok. Cheers! |
…and Twig (javiereguiluz)This PR was merged into the 2.3 branch.Discussion----------Added a note about the side effects of enabling both PHP and Twig| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes| Applies to | 2.3+| Fixed tickets |#3293Commits-------fbbabb1 Reworded the explanation about the limitation of enablin PHP templates5e47417 Improved the explanation thanks to@stof comments3828162 Added a note about the side effects of enabling both PHP and Twig