Adding 'attr' option to the Textarea options list#4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ronanguilloux wants to merge1 commit intosymfony:2.5fromronanguilloux:patch-1

Closed

Adding 'attr' option to the Textarea options list#4152

ronanguilloux wants to merge1 commit intosymfony:2.5fromronanguilloux:patch-1

Conversation

Copy link

Contributor

ronanguilloux commentedAug 20, 2014

Q	A
Doc fix?	yes
New docs?	nope
Applies to	all?
Fixed tickets	?

attr is a quite useful option, but not yet listed here, so I added it.
BTW, theattr.rst.inc file already includes anattr conf. example concerning textareas.

Adding 'attr' option to the Textarea options list

d6f9bd1

`attr` is a quite useful option, but not yet listed here. BTW, the `attr.rst.inc` file already includes an `attr` conf. example concerning textareas.

Copy link

Member

weaverryan commentedAug 22, 2014

Hey@ronanguilloux!

Hmm, you're right! This is one of the more important options, and we're actually missing it onevery field (in a few cases, like "collection", that's ok - I don't thinkattr makes sense for it).

I think we should add this option to ever field that it makes sense to. That's a bit of work. Would you like to do it? If not, no worries - I'll merge this PR and we'll add it in another.

Thanks!

Copy link

Member

weaverryan commentedAug 22, 2014

Also, if youdo add it to the other fields, we'll need this PR to be rebased onto the 2.3 branch (else we'll likely get merge conflicts trying to merge this into 2.3):#4134 (comment)

Thanks!