Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

cleaned up the code example#4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
gondo wants to merge1 commit intosymfony:2.5fromgondo:patch-4
Closed

cleaned up the code example#4139

gondo wants to merge1 commit intosymfony:2.5fromgondo:patch-4

Conversation

@gondo
Copy link

  • added final return forvote() function
  • moved$user below attribute check. if attribute fails, we don't need user
  • used already declared constants in switch statement, rather than harcoded strings

- added final return for `vote()` function- moved `$user` below attribute check. if attribute fails, we don't need user- used already declared constants in switch statement, rather than harcoded strings
@xabbuh
Copy link
Member

👍 nice changes@gondo

@weaverryan
Copy link
Member

Love these - thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gondo@xabbuh@weaverryan@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp