Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Missing backtick#4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Baptouuuu wants to merge1 commit intosymfony:2.5fromBaptouuuu:typo-2.5
Closed

Missing backtick#4134

Baptouuuu wants to merge1 commit intosymfony:2.5fromBaptouuuu:typo-2.5

Conversation

@Baptouuuu
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.5+
Fixed tickets

@xabbuh
Copy link
Member

👍

@weaverryan
Copy link
Member

Hey@Baptouuuu!

I have the same problem here as#4130. Can you rebase?

git fetch upstreamgit checkout typo-2.5git rebase --onto upstream/2.3 upstream/2.5git push origin typo-2.5 --force

Thanks!

@Baptouuuu
Copy link
ContributorAuthor

@weaverryan done

@wouterj
Copy link
Member

Hmm, ryan, I think you've suggested something wrong. This PR should be merged into the 2.5 branch, not 2.3.

@Baptouuuu I'm afraid you have to execute the same commands again, but than withgit rebase --onto upstream/2.5 upstream/2.3

@weaverryan
Copy link
Member

Unless I'm missing something, it looks like there are no changes in this PR anymore! Perhaps the backtick was added and so now is no longer needed?

Thanks!

@xabbuh
Copy link
Member

@weaverryan I don't think so. There haven't been any related changes recently.

@javiereguiluz
Copy link
Member

I think@weaverryan is right. The changes made by this PR no longer relate to a missing backtick. Should we close this issue then?

@xabbuh
Copy link
Member

@javiereguiluz I'm pretty sure that the change was necessary and that it wasn't covered anywhere else. Though I don't remember what it was. :(

@javiereguiluz
Copy link
Member

@xabbuh if nobody know what this issue is about, we should close it. And don't worry about this mysterious error. If it's important, someone else will open a new issue in the future.

@wouterj
Copy link
Member

Found it :)#4212

@javiereguiluz
Copy link
Member

Great detective work Wouter!

weaverryan added a commit that referenced this pull requestSep 15, 2014
This PR was merged into the 2.5 branch.Discussion----------Missing backtick, thanks to@BaptouuuuSee#4134Commits-------dadaea3 Missing backtick, thanks to@Baptouuuu
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Baptouuuu@xabbuh@weaverryan@wouterj@javiereguiluz

[8]ページ先頭

©2009-2025 Movatter.jp