Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Missing backtick#4134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Missing backtick#4134
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Baptouuuu commentedAug 16, 2014
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.5+ |
| Fixed tickets |
xabbuh commentedAug 16, 2014
👍 |
weaverryan commentedAug 16, 2014
Hey@Baptouuuu! I have the same problem here as#4130. Can you rebase? git fetch upstreamgit checkout typo-2.5git rebase --onto upstream/2.3 upstream/2.5git push origin typo-2.5 --force Thanks! |
Baptouuuu commentedAug 17, 2014
@weaverryan done |
wouterj commentedAug 17, 2014
Hmm, ryan, I think you've suggested something wrong. This PR should be merged into the 2.5 branch, not 2.3. @Baptouuuu I'm afraid you have to execute the same commands again, but than with |
weaverryan commentedAug 22, 2014
Unless I'm missing something, it looks like there are no changes in this PR anymore! Perhaps the backtick was added and so now is no longer needed? Thanks! |
xabbuh commentedAug 22, 2014
@weaverryan I don't think so. There haven't been any related changes recently. |
javiereguiluz commentedSep 8, 2014
I think@weaverryan is right. The changes made by this PR no longer relate to a missing backtick. Should we close this issue then? |
xabbuh commentedSep 8, 2014
@javiereguiluz I'm pretty sure that the change was necessary and that it wasn't covered anywhere else. Though I don't remember what it was. :( |
javiereguiluz commentedSep 8, 2014
@xabbuh if nobody know what this issue is about, we should close it. And don't worry about this mysterious error. If it's important, someone else will open a new issue in the future. |
wouterj commentedSep 8, 2014
Found it :)#4212 |
javiereguiluz commentedSep 8, 2014
Great detective work Wouter! |
This PR was merged into the 2.5 branch.Discussion----------Missing backtick, thanks to@BaptouuuuSee#4134Commits-------dadaea3 Missing backtick, thanks to@Baptouuuu