Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use ${APACHE_LOG_DIR} instead of /var/log/apache2#4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
noppelmax wants to merge2 commits intosymfony:2.5fromnoppelmax:patch-1
Closed

Use ${APACHE_LOG_DIR} instead of /var/log/apache2#4104

noppelmax wants to merge2 commits intosymfony:2.5fromnoppelmax:patch-1

Conversation

@noppelmax
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies toall
Fixed ticketsnone

It would be a better solution to use envs in the configfile.

@xabbuh
Copy link
Member

👍

@weaverryan
Copy link
Member

Is theAPACHE_LOG_DIR environment variable consistently set in all Apache environments? I want this to work for as many people as possible without a headache. IfAPACHE_LOG_DIR isalways set, then clearly that's better (since your real log dir will differ in installations).

Thanks!

@noppelmax
Copy link
ContributorAuthor

I did some research and found that it is not provided by the apache2-bin. But apache2-bin is a non-optional dependency of the gnome desktop and APACHE_LOG_DIR seems to be provided by gnome and some other programs. Means, i cant give you a security that it is present on ALL systems.

@weaverryan
Copy link
Member

Hmm, I'm personally -1 on this. I had actually never heard of this variable, and I think it'll cause confusion. Even if it may be a best practice, I don't want to confuse people :).

@xabbuh
Copy link
Member

After@weaverryan's question I searched a bit for this and it seems that the way to use an environment variable is mainly used in Linux distributions (especially Debian based ones). So, having this by default may confuse a lot of people not using such distributions. What do you think about adding a tip stating that your distribution may support this environment variable, but that you have to check it?

@weaverryan
Copy link
Member

@xabbuh Awesome, thanks for the research! I would say that we shouldnot make this change then. At most, we could add a note below the code block - something like: "Some Apache installations have an environment variable for the log directory" - followed by how one of these lines would look with theAPACHE_LOG_DIR variable.

@noppelmax
Copy link
ContributorAuthor

That would be a good idea i think. The ones that giv something about having a clean system und want to use the variables will use it and the other ones wont be confused. +1 for this solution.

@weaverryan
Copy link
Member

@xamgreen Perfect! Do you want to under your change then and add a note below?

Thanks!

Added a note, that for systems, which support the APACHE_LOG_DIR env, the user can use it for the logging-path.
@weaverryan
Copy link
Member

I've made one tiny little tweak to the language, but looks great. Thanks @xamgreen!

weaverryan added a commit that referenced this pull requestOct 19, 2014
* 2.3:  [#4104] Re-organizing language in one sentence  APACHE_LOG_DIR note added  Use ${APACHE_LOG_DIR} instead of /var/log/apache2
weaverryan added a commit that referenced this pull requestOct 19, 2014
* 2.5:  [#4104] Re-organizing language in one sentence  APACHE_LOG_DIR note added  Use ${APACHE_LOG_DIR} instead of /var/log/apache2
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noppelmax@xabbuh@weaverryan@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp