Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Update http_cache.rst#4098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Explained how the parameters are passed to the controller - named parameters
public function content($max_per_page = 10, $type = "news") | ||
{ | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hmm, I agree we can highlight this better. But it's also true ofrender
, not onlyrender_esi
. Also, I think the standards aremaxPerPage
and the controller name should becontentAction
(since most people are probably using the normal shortcut syntax for the controller.
Wedo show the$max
variable being passed as an argument in the next example. Perhaps we just need to add a note about that. For example:
..tip:: Any extra variables you pass (like ``max`` in the above example) will become arguments to your controller (e.g. ``$max``). You can see this in the controller below.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree, but I think we need to be explicit with the named part. Those variables were just made up to be honest, Easy to change :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@Farkie You want to be explicit with the named part? So what do you mean/propose exactly? Sorry, I don't understand - I think you agree with changing the variable names but I'm not sure what you think about my other points :). Can you make the changes you think make sense? That might help.
Thanks!
This PR was merged into the 2.3 branch.Discussion----------ESI Variable Details ContinuationThis continues#4098.| Q | A| ------------- | ---| Doc fix? | no| New docs? | no| Applies to | 2.3+| Fixed tickets | n/aThanks!Commits-------ded7577 Clarifying a bit more that you're passing variables into your controller5877d02 Update http_cache.rst
Explained how the parameters are passed to the controller - named parameters