Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Console] Fix Console QuestionHelper $app to $this#3952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cordoval commentedJun 14, 2014
true although you could have gotten the $app from $app = $this->getApplication(), also notice that $this->getApplication() is tagged @api so it is here to stay. But yeah this is a 👍 |
wouterj commentedJun 14, 2014
👍 we never told what the However, maybe changing it to |
Fix getHelperSet() to getHelper()Typo fixMove getHelperSet() to getHelper() in other files
eko commentedJun 14, 2014
Yes, it was confusing. I've updated the PR to use |
cordoval commentedJun 14, 2014
👍 |
weaverryan commentedJun 20, 2014
Hi guys! Yes, this is much better. But, I need your help! Most of these changes apply to all versions (back to 2.3), but some (
@eko Can you help out with this? Thanks! |
eko commentedJun 21, 2014
Hi@weaverryan, Alright, I will create 2 new PRs against 2.3 and 2.5 branches in the week-end. Thank you |
weaverryan commentedJun 22, 2014
Thanks@eko! |
eko commentedJul 5, 2014
Hi@weaverryan, I've sent the 2 PRs against 2.3 and 2.5 branches:
So I think this PR can be closed? Thank you |
…getHelper() (eko)This PR was merged into the 2.3 branch.Discussion----------[Console] Fix Console component getHelperSet()->get() to getHelper()| Q | A || ---------------- |:---------:|| Doc fix? | Yes || New docs? | No || Applies to | 2.3 || Fixed tickets | No |On Console component, I've fixed the following calls:```php$this->getHelperSet()->get('dialog');```to:```php$this->getHelper('dialog');```This is related to original PR#3952Commits-------9207f68 [Console] Fix Console component getHelperSet()->get() to getHelper()…getHelper() method (eko)This PR was merged into the 2.5 branch.Discussion----------[Console] Fix Console component $app to $this and use of getHelper() method| Q | A || ---------------- |:---------:|| Doc fix? | Yes || New docs? | No || Applies to | 2.5 || Fixed tickets | No |On Console component, I've fixed the following:### Use of getHelper() method```php$this->getHelperSet()->get('dialog');```to:```php$this->getHelper('dialog');```### Also fixed unusued $app variable to $thisThis is related to original PR#3952Commits-------1f4dc76 [Console] Fix Console some $app to $this and getHelperSet()->get() to getHelper()
On
QuestionHelperpage, commands examples for callinggetHelperSetuse the following (where $app is undefined):I've changed it to correct: