I don't think having a cookbook for each makes sense because so much duplication. Instead both should be merged and the title more general.

Hi Joaquín!

Thanks very much for adding this! I agree with@Tobion that we should modify the existing cookbook entry and add details on how you would use the DBAL to it. We can certainly change its title to be more generic.

What do you think?

Thanks!

I completely agree. I'll mix my changes into the old file.
About the title, does "How to store Session in the database" sound ok?

About the title, does "How to store Session in the database" sound ok?

Sounds good to me. Though, according to our standards it should be written "How to Store Session in the Database".

ping@xocasdashdash Can you please update this PR? (if you don't have time, feel free to say so, then somebody else will take it over from you)

I will get on it this week and deliver an update by Saturday.

2014-09-16 15:03 GMT+02:00 Wouter Jnotifications@github.com:

ping@xocasdashdashhttps://github.com/xocasdashdash Can you please
update this PR? (if you don't have time, feel free to say so, then somebody
else will take it over from you)

—
Reply to this email directly or view it on GitHub
#3914 (comment).

Joaquín Fernández Campo
E-Mail:jfcampo@gmail.com

ping@wouterj . Any news on these?
Github says there's a merge conflict but I can't find it

@xocasdashdash Sorry for the delay! I've just added some feedback :).

Cheer!

No worries!
I'll try to fix everything tomorrow. Another question, any idea how can I see the way the docs are gonna look online? I'm flying blind right now

@xocasdashdash you can't (we're working on that). You can however install python and sphinx locally and render it using a default sphinx theme. Seehttp://symfony.com/doc/current/contributing/documentation/overview.html for more information.

And if you rebase (git rebase origin/master, where origin is this original repository), the PR gets a travis build which tests for errors.

Ping?

I'm gonna work on some of the changes proposed by@weaverryan, I agree with most of them, and squash the different commits into one

FYI, in master (upcoming 2.6) the enhancements for PdoSessionHandler (symfony/symfony#10931) are not yet implemented for DoctrineSessionHandler. So currently they are quite different in terms of feature set.

@Tobion mmm I see there's quite a bit of discussion on that thread. I'm thinking of how to add this info here, but as@weaverryan said, choices suck unless we can help them decide.
I'll keep on working on this merge this week and will update asap

yes, I agree

Ok, I'll rework@weaverryan last proposal changes into the docs

@xocasdashdash can you please update this PR?

The DbalSessionHandler has not been updated for 2.6. So I believe the recommendation is now to use the PdoSessionHandler.

I won't be able to until the 15th or so of this month. Is that workable?

@xocasdashdash Of course, we know that everyone does the work on the docs in their spare time. We are really looking forward to see you back soon. However, feel free to ping us if you think you won't have the time and we'll find someone who finishes your great work.

@xocasdashdash Do you think you can finish this? :)

@xabbuh Ok! If i don't finish it this week don't hesitate on rejecting/closing it and assigning it to somebody else!

@xabbuh Ok, I think i'm finished, how can I check that everything's correct format wise? How should I proceed?

@xocasdashdash I've just added some formatting comments. If you fix those, you should be ready to go.

There is also a merge conflict, can you please rebase onto 2.3 (As that's the branch where this PR is going to be merged into).

Assumingorigin points to this repository andxocasdashdash to your fork:

$ git fetch origin$ git rebase --onto origin/2.3 origin/master$ git push -f including_dbalsession_doc xocasdashdash

If you've solved the conflict, this PR can also be build by Travis, which checks for syntax errors.

Btw, why did you create adbal_session_storage article with the same content as the newdatabase_session_storage article?

@wouterj I've tried to fix the merge conflicts, but I can't seem to get it right 😕

@xocasdashdash To be build on Travis, your pull request has to be rebased onto the branch you want to merge in (master in your case). Alternatively, you can open a new pull request with your (already rebased on the2.3 branch) changes for the2.3 branch.

Hi@xocasdashdash!

Do you have time to update your PR? We have adoc sprint day on May 23rd and we would like to finish as much PRs as possible before/during that PR.

Don't worry if you have no time soon, we know it's all freetime work.@javiereguiluz already started a new PR without knowing this PR existed:#5019 you can also comment on that PR with some details that you think are missing from his PR and close this PR.

If you need any help, you can almost always find one of us on the #symfony-docs IRC freenode channel.

Thanks!

@wouterj I've checked@javiereguiluz PR and it looks fine by me.

I'm gonna close down this PR then!