Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Components][Form] Fixed version specific examples of some form events.#3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

ahsio
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.3
Fixed tickets
  • Examples that point to DataCollectorListener (added since 2.4) should be removed (or adapted when it's possible).
  • This fixonly applies to 2.3.

@weaverryan
Copy link
Member

You're right! Since these are just examples to help you understand the purpose of what a listener might be doing on each even, what if we just added a very small note about these being a 2.4 feature? I don't think mentioning the listener in the 2.3 docs is a problem (as long as we avoid causing any confusion by pointing out that you won't see this listener unless you're looking at the 2.4 codebase).

What do you think@ahsio?

weaverryan added a commit that referenced this pull requestJun 7, 2014
…r form extension (xabbuh)This PR was merged into the 2.4 branch.Discussion----------[Components][Form] add versionadded for the data collector form extension| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | 2.4+| Fixed tickets |As@ahsio pointed out in#3886, the data collector extension was added to the Form component in Symfony 2.4.Commits-------beceed4 add versionadded for the data collector form extension
@ahsio
Copy link
ContributorAuthor

@weaverryan I do agree with you.@xabbuh 's commit should then be applied to 2.3+

Also, 2.3 links toDataCollectorListener class should point tothe 2.4 version of the API.

@weaverryan
Copy link
Member

@ahsio So, after merging#3887, I actually think things arealmost perfect. As I mentioned, I don't mind having the notes there, even on 2.3. But you're right that the API doc links will 404 on 2.3, which I didn't think of before. So, I think what we need to do is remove the API links on 2.3 (or all versions, I don't think they add much here) or convert them to code links (e.g. a link to that file on GitHub).

What do you think?

@wouterj
Copy link
Member

+1 for leaving the note in here
+1 for removing the API link in 2.3
-1 for using code links

@ahsio can you please update? (if you don't have time, please say so, somebody else will do it then)

@wouterjwouterj mentioned this pull requestSep 16, 2014
@wouterj
Copy link
Member

Replaced by#4237

weaverryan added a commit that referenced this pull requestOct 2, 2014
This PR was merged into the 2.3 branch.Discussion----------Finished#3886Replaces#3886Commits-------01057ae Reverted removal, removed API links instead0670f25 [2.3] Examples that points to the DataCollectorListener should be removed.
@ahsioahsio deleted the fix-added-example-to-wrong-version branchDecember 10, 2014 15:08
@ahsio
Copy link
ContributorAuthor

@wouterj@weaverryan Sorry for not being able to adresse your questions on time! Thanks for fixing the issue!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ahsio@weaverryan@wouterj

[8]ページ先頭

©2009-2025 Movatter.jp